fix: resolve co-variant array conversion warnings (HitSampleInfo[] to ISampleInfo[])

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/258720a5-84bc-4283-b524-809219539b6a

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSlider.cs

@@ -162,8 +162,8 @@ protected override void OnFree()
         protected override void LoadSamples()
         {
             // Note: base.LoadSamples() isn't called since the slider plays the tail's hitsounds for the time being.
-            Samples.Samples = HitObject.TailSamples.ToArray();
-            slidingSample.Samples = HitObject.CreateSlidingSamples().ToArray();
+            Samples.Samples = HitObject.TailSamples.Cast<ISampleInfo>().ToArray();
+            slidingSample.Samples = HitObject.CreateSlidingSamples().Cast<ISampleInfo>().ToArray();
         }
 
         public override void StopAllSamples()

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinner.cs

@@ -143,7 +143,8 @@ protected override void LoadSamples()
         {
             base.LoadSamples();
 
-            spinningSample.Samples = HitObject.CreateSpinningSamples().ToArray();
+            spinningSample.Samples = HitObject.CreateSpinningSamples().Cast<ISampleInfo>().ToArray();
+
             spinningSample.Frequency.Value = spinning_sample_initial_frequency;
 
             maxBonusSample.Samples = new ISampleInfo[] { new SpinnerBonusMaxSampleInfo(HitObject.CreateHitSampleInfo()) };

osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs

@@ -389,8 +389,7 @@ protected virtual void OnFree()
         /// </summary>
         protected virtual void LoadSamples()
         {
-            // HitSampleInfo : ISampleInfo, so array covariance lets us avoid a second .Cast<ISampleInfo>().ToArray() allocation.
-            var samples = (ISampleInfo[])GetSamples().ToArray();
+            var samples = GetSamples().Cast<ISampleInfo>().ToArray();
 
             if (samples.Length <= 0)
                 return;

osu.Game/Rulesets/UI/GameplaySampleTriggerSource.cs

@@ -68,9 +68,7 @@ public virtual void Play()
             if (nextObject == null)
                 return;
 
-            // HitSampleInfo : ISampleInfo (reference type) — array covariance makes the assignment
-            // implicit; no explicit cast or second array allocation needed.
-            PlaySamples(nextObject.Samples.ToArray());
+            PlaySamples(nextObject.Samples.Cast<ISampleInfo>().ToArray());
         }
 
         protected virtual void PlaySamples(ISampleInfo[] samples) => Schedule(() =>