perf: reduce allocations in beatmap conversion, playable bounds, and HUD components

- BeatmapConverter: replace OrderBy().ToList() with in-place List<T>.Sort()
  to avoid creating an intermediate IOrderedEnumerable and a second list.

- IBeatmap.CalculatePlayableBounds: collapse three separate LINQ enumerations
  (Any, Max, First) into a single foreach loop. Reduces from O(3n) to O(n)
  and eliminates two LINQ iterator allocations on every call site.

- PausableSkinnableSound.Length: previously evaluated DrawableSamples twice
  (once for Any(), once for Max()), creating two LINQ chains. Replaced with
  a single foreach that accumulates the maximum sample length.

- JudgementCounter, JudgementCounterDisplay, ArgonJudgementCounter,
  ArgonJudgementCounterDisplay: replaced Types.First() with direct Types[0]
  array indexing and removed the now-unused 'using System.Linq' imports.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game/Beatmaps/BeatmapConverter.cs

@@ -70,7 +70,9 @@ protected virtual Beatmap<T> ConvertBeatmap(IBeatmap original, CancellationToken
 
             beatmap.BeatmapInfo = original.BeatmapInfo;
             beatmap.ControlPointInfo = original.ControlPointInfo;
-            beatmap.HitObjects = convertHitObjects(original.HitObjects, original, cancellationToken).OrderBy(s => s.StartTime).ToList();
+            var hitObjects = convertHitObjects(original.HitObjects, original, cancellationToken);
+            hitObjects.Sort((a, b) => a.StartTime.CompareTo(b.StartTime));
+            beatmap.HitObjects = hitObjects;
             beatmap.Breaks = original.Breaks;
             beatmap.AudioLeadIn = original.AudioLeadIn;
             beatmap.StackLeniency = original.StackLeniency;

osu.Game/Beatmaps/IBeatmap.cs

@@ -196,13 +196,24 @@ public static double CalculatePlayableLength(IEnumerable<HitObject> objects)
         /// </summary>
         public static (double start, double end) CalculatePlayableBounds(IEnumerable<HitObject> objects)
         {
-            if (!objects.Any())
-                return (0, 0);
+            double firstObjectTime = double.MaxValue;
+            double lastObjectTime = double.MinValue;
+            bool any = false;
 
-            double lastObjectTime = objects.Max(o => o.GetEndTime());
-            double firstObjectTime = objects.First().StartTime;
+            foreach (var obj in objects)
+            {
+                any = true;
+
+                if (obj.StartTime < firstObjectTime)
+                    firstObjectTime = obj.StartTime;
+
+                double endTime = obj.GetEndTime();
+
+                if (endTime > lastObjectTime)
+                    lastObjectTime = endTime;
+            }
 
-            return (firstObjectTime, lastObjectTime);
+            return any ? (firstObjectTime, lastObjectTime) : (0, 0);
         }
 
         #endregion

osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCounter.cs

@@ -1,7 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-using System.Linq;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
@@ -52,7 +51,7 @@ private void load(OsuColour colours)
                 }
             };
 
-            var result = Result.Types.First();
+            var result = Result.Types[0];
 
             Colour = result.IsBasic() ? colours.ForHitResult(result) : !result.IsBonus() ? colours.PurpleLight : colours.PurpleLighter;
         }

osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCounterDisplay.cs

@@ -2,7 +2,6 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
-using System.Linq;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
@@ -89,7 +88,7 @@ bool shouldShow(int index, JudgementCounter counter)
                 if (index == 0 && !ShowMaxJudgement.Value)
                     return false;
 
-                var hitResult = counter.Result.Types.First();
+                var hitResult = counter.Result.Types[0];
 
                 switch (Mode.Value)
                 {

osu.Game/Skinning/Components/ArgonJudgementCounter.cs

@@ -2,7 +2,6 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
-using System.Linq;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
 using osu.Framework.Extensions.LocalisationExtensions;
@@ -57,7 +56,7 @@ protected override void LoadComplete()
                 updateWireframe();
             }, true);
 
-            var result = Result.Types.First();
+            var result = Result.Types[0];
             textComponent.LabelColour.Value = getJudgementColor(result);
             textComponent.ShowLabel.BindValueChanged(v => textComponent.TextColour.Value = !v.NewValue ? getJudgementColor(result) : Colour4.White, true);
         }

osu.Game/Skinning/Components/ArgonJudgementCounterDisplay.cs

@@ -117,7 +117,7 @@ private bool shouldBeVisible(int index, ArgonJudgementCounter counter)
             if (index == 0 && !ShowMaxJudgement.Value)
                 return false;
 
-            var hitResult = counter.Result.Types.First();
+            var hitResult = counter.Result.Types[0];
 
             switch (Mode.Value)
             {

osu.Game/Skinning/PausableSkinnableSound.cs

@@ -3,8 +3,8 @@
 
 #nullable disable
 
+using System;
 using System.Collections.Generic;
-using System.Linq;
 using JetBrains.Annotations;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
@@ -15,7 +15,18 @@ namespace osu.Game.Skinning
 {
     public partial class PausableSkinnableSound : SkinnableSound
     {
-        public double Length => !DrawableSamples.Any() ? 0 : DrawableSamples.Max(sample => sample.Length);
+        public double Length
+        {
+            get
+            {
+                double max = 0;
+
+                foreach (var sample in DrawableSamples)
+                    max = Math.Max(max, sample.Length);
+
+                return max;
+            }
+        }
 
         public bool RequestedPlaying { get; private set; }