Skip to content

Commit 3ffb519

Browse files
Address code review: clarify store password fallback chain in release workflow
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/c9e6ebec-a8b6-4aa8-b446-27812ab3b780 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 parent 682155b commit 3ffb519

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,13 @@ jobs:
100100
# Priority: workflow_dispatch inputs > repository secrets > auto-generate.
101101
# This lets users paste values from SAVE-THESE-SECRETS.txt directly into
102102
# the "Run workflow" form so they don't need to set up repo secrets.
103+
# Note: the auto-generated keystore uses the same password for both key and
104+
# store, so a single key_password input covers both. Users with separate
105+
# passwords should use repository secrets instead of workflow inputs.
103106
EFFECTIVE_KS="${INPUT_KEYSTORE_BASE64:-$KEYSTORE_BASE64}"
104107
EFFECTIVE_ALIAS="${INPUT_KEY_ALIAS:-$KEY_ALIAS_SECRET}"
105108
EFFECTIVE_PASS="${INPUT_KEY_PASSWORD:-$KEY_PASS_SECRET}"
106-
EFFECTIVE_STORE_PASS="${INPUT_KEY_PASSWORD:-$STORE_PASS_SECRET}"
109+
EFFECTIVE_STORE_PASS="${INPUT_KEY_PASSWORD:-${STORE_PASS_SECRET:-$EFFECTIVE_PASS}}"
107110
108111
# Mask passwords so they never appear in logs.
109112
if [ -n "$EFFECTIVE_PASS" ]; then echo "::add-mask::$EFFECTIVE_PASS"; fi

0 commit comments

Comments
 (0)