fix: resolve CI build errors (RendererType.OpenGLLegacy, naming, IDE0032)

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/e8cdcda3-c212-4191-a5f5-02a45f160c92

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game/IO/Stores/OptimisedMediaResourceStore.cs

@@ -18,7 +18,7 @@ namespace osu.Game.IO.Stores
     /// </remarks>
     public class OptimisedMediaResourceStore : ResourceStore<byte[]>
     {
-        private static readonly Dictionary<string, string[]> extensionPreferences = new Dictionary<string, string[]>
+        private static readonly Dictionary<string, string[]> extension_preferences = new Dictionary<string, string[]>
         {
             // Keep in sync with OptimizedResourceStore.ImageFallbackRules in osu-framework.
             // avif first (better compression), webp second (broad compat), original last.
@@ -43,7 +43,7 @@ protected override IEnumerable<string> GetFilenames(string name)
             string extension = Path.GetExtension(name);
             string normalisedExtension = extension.ToLowerInvariant();
 
-            if (!string.IsNullOrEmpty(extension) && extensionPreferences.TryGetValue(normalisedExtension, out string[]? alternatives))
+            if (!string.IsNullOrEmpty(extension) && extension_preferences.TryGetValue(normalisedExtension, out string[]? alternatives))
             {
                 foreach (string alternative in alternatives)
                     yield return Path.ChangeExtension(name, alternative);

osu.Game/Overlays/Settings/Sections/Graphics/RendererSettings.cs

@@ -89,10 +89,7 @@ private void load(FrameworkConfigManager config, OsuConfigManager osuConfig, IDi
                 {
                     Caption = GraphicsSettingsStrings.Renderer,
                     Current = renderer,
-                    Items = rendererItems.Order()
-#pragma warning disable CS0612, CS0618
-                                .Where(t => t != RendererType.OpenGLLegacy),
-#pragma warning restore CS0612, CS0618
+                    Items = rendererItems.Order(),
                 })
                 {
                     Keywords = new[] { @"compatibility", @"directx" },

osu.Game/Screens/OnlinePlay/Matchmaking/Queue/CloudVisualisation.cs

@@ -27,25 +27,23 @@ public partial class CloudVisualisation : CompositeDrawable
 
         private readonly Bindable<double?> lastSamplePlayback = new Bindable<double?>();
 
-        private APIUser[] users = [];
-
         public APIUser[] Users
         {
-            get => users;
+            get;
             set
             {
-                users = value;
+                field = value;
                 if (IsLoaded)
                     refresh();
             }
-        }
+        } = [];
 
         private void refresh()
         {
             foreach (var u in usersContainer)
                 u.Delay(RNG.Next(0, 1000)).FadeOut(500).Expire();
 
-            LoadComponentsAsync(users.Select(u => new MovingAvatar(u, lastSamplePlayback)), avatars =>
+            LoadComponentsAsync(Users.Select(u => new MovingAvatar(u, lastSamplePlayback)), avatars =>
             {
                 if (usersContainer.Count == 0)
                 {