Fix security issues in native bridges: add Vulkan error checking, bounds-safe memset, volatile dispose flags, cleanup on probe failure

Author: Copilot

osu.Android/Native/OboeAudioBridge.cs

@@ -14,7 +14,7 @@ namespace osu.Android.Native
     public sealed class OboeAudioBridge : IDisposable
     {
         private long nativePtr;
-        private bool disposed;
+        private volatile bool disposed;
 
         /// <summary>
         /// Creates and opens a new low-latency Oboe audio stream.

osu.Android/Native/VulkanProbe.cs

@@ -14,7 +14,7 @@ namespace osu.Android.Native
     public sealed class VulkanProbe : IDisposable
     {
         private long nativePtr;
-        private bool disposed;
+        private volatile bool disposed;
 
         /// <summary>
         /// Creates a Vulkan probe. Returns null if native library is unavailable.

osu.Android/Native/oboe_bridge.cpp

@@ -87,7 +87,10 @@ oboe::DataCallbackResult OboeBridge::onAudioReady(
 
     // Output silence - the primary purpose of this stream is latency measurement.
     // Future: route game audio through this path for lowest possible latency.
-    memset(audioData, 0, numFrames * stream->getChannelCount() * sizeof(float));
+    size_t byteCount = static_cast<size_t>(numFrames)
+                     * static_cast<size_t>(stream->getChannelCount())
+                     * sizeof(float);
+    memset(audioData, 0, byteCount);
 
     updateLatency();
 

osu.Android/Native/vulkan_bridge.cpp

@@ -14,6 +14,10 @@
 VulkanProbe::VulkanProbe() {
     available_ = createInstance() && queryDevice();
 
+    if (!available_) {
+        cleanup();
+    }
+
     if (available_) {
         LOGI("Vulkan available: %s (API %u.%u.%u, driver %u)",
              deviceInfo_.deviceName.c_str(),
@@ -65,7 +69,11 @@ bool VulkanProbe::queryDevice() {
     }
 
     std::vector<VkPhysicalDevice> devices(deviceCount);
-    vkEnumeratePhysicalDevices(instance_, &deviceCount, devices.data());
+
+    if (vkEnumeratePhysicalDevices(instance_, &deviceCount, devices.data()) != VK_SUCCESS || deviceCount == 0) {
+        LOGE("Failed to enumerate Vulkan physical devices");
+        return false;
+    }
 
     // Pick the first discrete GPU, or fall back to the first device.
     VkPhysicalDevice selected = devices[0];
@@ -90,10 +98,18 @@ bool VulkanProbe::queryDevice() {
 
     // Check for swapchain extension support.
     uint32_t extCount = 0;
-    vkEnumerateDeviceExtensionProperties(selected, nullptr, &extCount, nullptr);
+
+    if (vkEnumerateDeviceExtensionProperties(selected, nullptr, &extCount, nullptr) != VK_SUCCESS || extCount == 0) {
+        deviceInfo_.supportsSwapchain = false;
+        return true;
+    }
 
     std::vector<VkExtensionProperties> extensions(extCount);
-    vkEnumerateDeviceExtensionProperties(selected, nullptr, &extCount, extensions.data());
+
+    if (vkEnumerateDeviceExtensionProperties(selected, nullptr, &extCount, extensions.data()) != VK_SUCCESS) {
+        deviceInfo_.supportsSwapchain = false;
+        return true;
+    }
 
     deviceInfo_.supportsSwapchain = false;