Skip to content

Commit 547ba2b

Browse files
Fix integer truncation in CatchBeatmapProcessor time delta calculation
Changed `timeDiff` calculation from `int` to `double` in `applyHardRockOffset` to prevent precision loss which was affecting randomization and offset application. Updated expected values for `CatchBeatmapConversionTest` case `1431386` as the fix alters Hard Rock object positions. Added `CatchBeatmapProcessorTest` to verify the fix. Fixed code style issues (license header, object initializer, formatting). Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 parent 05a2b14 commit 547ba2b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

osu.Game.Rulesets.Catch.Tests/CatchBeatmapProcessorTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
22
// See the LICENCE file in the repository root for full licence text.
33

4+
using System.Collections.Generic;
45
using NUnit.Framework;
56
using osu.Game.Beatmaps;
67
using osu.Game.Rulesets.Catch.Beatmaps;
78
using osu.Game.Rulesets.Catch.Objects;
8-
using System.Collections.Generic;
99

1010
namespace osu.Game.Rulesets.Catch.Tests
1111
{

0 commit comments

Comments
 (0)