Commit 71b3d51
Bartłomiej Dach
Rewrite ranked play card song preview playback logic to hopefully work around framework breakage (ppy#37453)
Similar idea to
ppy@622216d
(which was included in ppy#37218).
Probably closes ppy#37420.
I wouldn't be myself if I didn't remark that the WTF/sec on ranked play
code continues to be quite high as I fix these issues. Like, look at the
old code: why does `Enabled` becoming false stop the preview track, but
`CardHovered` becoming false *doesn't*? Even though `shouldBePlaying`
was explicitly defined as derived from *both flags*? Maybe me changing
this to be actually consistent incurs a behaviour change, but like... I
can't tell if it is a bug or not.
Not to mention this nugget:
https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/HandOfCards.HandCard.cs#L107
https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs#L47-L50
What is this naming even?1 parent 71356a9 commit 71b3d51
1 file changed
Lines changed: 22 additions & 33 deletions
Lines changed: 22 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | 48 | | |
51 | 49 | | |
52 | 50 | | |
| |||
77 | 75 | | |
78 | 76 | | |
79 | 77 | | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | 78 | | |
108 | 79 | | |
109 | 80 | | |
| |||
126 | 97 | | |
127 | 98 | | |
128 | 99 | | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | 100 | | |
133 | 101 | | |
134 | 102 | | |
135 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
136 | 125 | | |
137 | 126 | | |
138 | 127 | | |
| |||
0 commit comments