Commit 854648d
Force MultiThreaded execution mode and remove SingleThread UI option
SingleThread is incompatible with the Android Vulkan surface-readiness
path (VeldridDevice polls SurfaceHandle for up to 5s on the same thread
that publishes it in SingleThread mode -> deadlock -> null Vulkan func
ptr -> SDLThread SI_TKILL crash within ~5s of launch, which matches the
tablet crash report).
The same pattern would also bite iOS Metal drawable attach. On desktop
SingleThread is just slower with no UX benefit. Upstream ppy/osu defaults
to MultiThreaded; we now enforce it on every startup so a stale
framework.ini cannot pin a user into the broken mode.
- OsuGameBase.load: force ExecutionMode = MultiThreaded once on load.
- RendererSettings: drop the Threading Mode dropdown.
- GraphicsSettingsStrings: drop the now-unused ThreadingMode string.
- TestSceneOsuGame: drop TestSwitchThreadExecutionMode (covered behaviour
is no longer user-reachable) and prune the now-unused usings.
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/cccaf70f-1049-4fde-a21c-cd61a27bf8b2
Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>1 parent 50fd801 commit 854648d
4 files changed
Lines changed: 15 additions & 19 deletions
File tree
- osu.Game
- Localisation
- Overlays/Settings/Sections/Graphics
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | | - | |
14 | 12 | | |
15 | 13 | | |
16 | 14 | | |
| |||
104 | 102 | | |
105 | 103 | | |
106 | 104 | | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | 105 | | |
115 | 106 | | |
116 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | 32 | | |
38 | 33 | | |
39 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
329 | 329 | | |
330 | 330 | | |
331 | 331 | | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
332 | 347 | | |
333 | 348 | | |
334 | 349 | | |
| |||
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | 86 | | |
92 | 87 | | |
93 | 88 | | |
| |||
0 commit comments