Merge pull request #320 from winnerspiros/copilot/fix-osu-apk-crash-on-startup-again

fix(android): correct framework assembly names in Linker.xml to prevent startup crash

Author: winnerspiros

osu.Android/Linker.xml

@@ -62,22 +62,39 @@
   <!-- ═══════════════════════════════════════════════════════════════════════
        ppy framework
        ═══════════════════════════════════════════════════════════════════════
-       ppy.osu.Framework: DrawableComponentLookup and SourceGeneratedImplementationLookup
+       osu.Framework: DrawableComponentLookup and SourceGeneratedImplementationLookup
          use Type.GetType()/Activator.CreateInstance() for draw hierarchy resolution.
          Shader attribute scanning, TextureLoaderStore fallback chain, bindable system,
          resource store extension routing — all reflection-dependent.
-       ppy.osu.Framework.Android: Android-specific host, input handling, surface wrappers.
+       osu.Framework.Android: Android-specific host, input handling, surface wrappers.
          AndroidGameActivity carries the (IntPtr, JniHandleOwnership) JNI-activation
          constructor and RegisterAttribute-driven type-binding needed for all derived
          Activity/Fragment types.  Without preserve="all", ILLink will trim these
          constructors (they are only reachable via JNI, not through any managed call
          graph), causing TypeManager.Activate to throw NotSupportedException:
          "Could not activate JNI Handle ... as managed type 'osu.Android.OsuGameActivity'"
-         at startup — exactly the crash reported in the 2026.508.222 field log.
+         at startup.
        ppy.Veldrid.SPIRV: SPIR-V cross-compiler; dynamically loads shader reflector types.
+         (NuGet package ID and assembly name are both ppy.Veldrid.SPIRV — no mismatch.)
 
-       NOTE: ppy.osu.Framework and ppy.osu.Framework.Android originate from net10.0
-       NuGet packages and are not visible in ILLink's assembly search path at descriptor-
+       IMPORTANT — assembly name vs. NuGet package ID:
+       ILLink's <assembly fullname="..."> descriptor element matches against the CLR
+       assembly name (i.e. the value of <AssemblyName> in the project file), NOT the
+       NuGet package ID.  These two values are NOT always the same.  In particular:
+         NuGet package ID          →  CLR assembly name (AssemblyName in csproj)
+         ppy.osu.Framework         →  osu.Framework
+         ppy.osu.Framework.Android →  osu.Framework.Android
+         ppy.Veldrid.SPIRV         →  ppy.Veldrid.SPIRV   (same — no ppy. mismatch here)
+       Using the NuGet package ID instead of the assembly name causes the preserve rule
+       to be stored but never matched: ILLink looks for an assembly named
+       "ppy.osu.Framework.Android" in the link set, finds only "osu.Framework.Android",
+       skips preservation, and freely trims the JNI-activation constructor from
+       AndroidGameActivity.  The resulting startup crash ("Could not activate JNI Handle
+       ... as managed type 'osu.Android.OsuGameActivity'") is exactly what was reported
+       in the v2026.508.225 field log.
+
+       NOTE: osu.Framework and osu.Framework.Android originate from net10.0 NuGet
+       packages and are not visible in ILLink's assembly search path at descriptor-
        processing time.  ILLink therefore emits warning IL2007 ("Could not resolve
        assembly") for each entry.  This warning is BENIGN and EXPECTED: ILLink stores
        the preserve="all" rule in its internal table even when it cannot resolve the
@@ -86,9 +103,9 @@
        the stored rule and preserves the assembly in full.  Removing these entries
        "to silence the warnings" allows ILLink to freely trim JNI-only constructors
        from AndroidGameActivity, crashing the app on launch. -->
-  <assembly fullname="ppy.osu.Framework"         preserve="all" />
-  <assembly fullname="ppy.osu.Framework.Android" preserve="all" />
-  <assembly fullname="ppy.Veldrid.SPIRV"         preserve="all" />
+  <assembly fullname="osu.Framework"         preserve="all" />
+  <assembly fullname="osu.Framework.Android" preserve="all" />
+  <assembly fullname="ppy.Veldrid.SPIRV"     preserve="all" />
 
   <!-- ═══════════════════════════════════════════════════════════════════════
        Audio (ManagedBass)

osu.Android/OsuGameActivity.cs

@@ -27,8 +27,10 @@ namespace osu.Android
     // Declare ScreenOrientation in the manifest (rather than only assigning RequestedOrientation
     // at runtime in OnCreate) so Android creates the activity in landscape from the very first
     // frame — the SurfaceView is sized correctly on creation and there is no orientation-change
-    // event during startup. This is defensive hardening alongside the main fix in osu.Android.props
-    // (disabling trimming + profiled AOT, which was the actual cause of the startup crash).
+    // event during startup. This is defensive hardening alongside the linker fix in
+    // osu.Android/Linker.xml (using correct CLR assembly names osu.Framework /
+    // osu.Framework.Android instead of the NuGet package IDs ppy.osu.Framework /
+    // ppy.osu.Framework.Android, which was the actual cause of the startup crash).
     [Activity(ResizeableActivity = true, ScreenOrientation = ScreenOrientation.Landscape, ConfigurationChanges = ConfigChanges.Orientation | ConfigChanges.ScreenSize | ConfigChanges.UiMode | ConfigChanges.SmallestScreenSize | ConfigChanges.ScreenLayout | ConfigChanges.ColorMode | ConfigChanges.Density | ConfigChanges.Touchscreen | ConfigChanges.Keyboard | ConfigChanges.KeyboardHidden | ConfigChanges.Navigation, Exported = true, LaunchMode = DEFAULT_LAUNCH_MODE, MainLauncher = true)]
     [IntentFilter(new[] { Intent.ActionView }, Categories = new[] { Intent.CategoryDefault }, DataScheme = "content", DataPathPattern = ".*\\.osz", DataHost = "*", DataMimeType = "*/*")]
     [IntentFilter(new[] { Intent.ActionView }, Categories = new[] { Intent.CategoryDefault }, DataScheme = "content", DataPathPattern = ".*\\.osk", DataHost = "*", DataMimeType = "*/*")]