Avoid recomputing full path vertices in SliderPath when possible (ppy#36285)

In some cases `SliderPath.GetPathToProgress` used to compute the whole
path when it can be not needed since it can be already stored inside
`calculatedPath` list.
Also some of these use cases will no longer require additional array
wheen only readonly access is all we need.

Author: EVAST9919

osu.Game.Rulesets.Catch/Edit/Blueprints/Components/ScrollingPath.cs

@@ -18,6 +18,7 @@ public partial class ScrollingPath : CompositeDrawable
         private readonly Path drawablePath;
 
         private readonly List<(double Time, float X)> vertices = new List<(double, float)>();
+        private readonly List<Vector2> sliderVertices = new List<Vector2>();
 
         public ScrollingPath()
         {
@@ -47,9 +48,8 @@ public void UpdatePathFrom(ScrollingHitObjectContainer hitObjectContainer, Juice
         private void computeTimeXs(JuiceStream hitObject)
         {
             vertices.Clear();
-
-            var sliderVertices = new List<Vector2>();
-            hitObject.Path.GetPathToProgress(sliderVertices, 0, 1);
+            sliderVertices.Clear();
+            sliderVertices.AddRange(hitObject.Path.CalculatedPath);
 
             if (sliderVertices.Count == 0)
                 return;

osu.Game.Rulesets.Catch/Objects/JuiceStreamPath.cs

@@ -175,8 +175,7 @@ public void ResampleVertices(IEnumerable<double> sampleTimes)
         /// </remarks>
         public void ConvertFromSliderPath(SliderPath sliderPath, double velocity)
         {
-            var sliderPathVertices = new List<Vector2>();
-            sliderPath.GetPathToProgress(sliderPathVertices, 0, 1);
+            var sliderPathVertices = sliderPath.CalculatedPath;
 
             double time = 0;
 

osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/Components/SliderBodyPiece.cs

@@ -1,7 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-using System.Collections.Generic;
 using osu.Framework.Allocation;
 using osu.Framework.Graphics;
 using osu.Game.Graphics;
@@ -57,11 +56,7 @@ public override void UpdateFrom(Slider hitObject)
             if (lastVersion != hitObject.Path.Version.Value)
             {
                 lastVersion = hitObject.Path.Version.Value;
-
-                var vertices = new List<Vector2>();
-                hitObject.Path.GetPathToProgress(vertices, 0, 1);
-
-                body.SetVertices(vertices);
+                body.SetVertices(hitObject.Path.CalculatedPath);
             }
 
             OriginPosition = body.PathOffset;

osu.Game.Rulesets.Osu/Skinning/SnakingSliderBody.cs

@@ -105,7 +105,8 @@ public void Refresh()
                 return;
 
             // Generate the entire curve
-            drawableSlider.HitObject.Path.GetPathToProgress(CurrentCurve, 0, 1);
+            CurrentCurve.Clear();
+            CurrentCurve.AddRange(drawableSlider.HitObject.Path.CalculatedPath);
             SetVertices(CurrentCurve);
 
             // Force the body to be the final path size to avoid excessive autosize computations

osu.Game.Rulesets.Osu/Utils/OsuHitObjectGenerationUtils.Reposition.cs

@@ -265,17 +265,14 @@ private static void applyDecreasingShift(IList<OsuHitObject> hitObjects, Vector2
         /// </remarks>
         public static RectangleF CalculatePossibleMovementBounds(Slider slider)
         {
-            var pathPositions = new List<Vector2>();
-            slider.Path.GetPathToProgress(pathPositions, 0, 1);
-
             float minX = float.PositiveInfinity;
             float maxX = float.NegativeInfinity;
 
             float minY = float.PositiveInfinity;
             float maxY = float.NegativeInfinity;
 
             // Compute the bounding box of the slider.
-            foreach (var pos in pathPositions)
+            foreach (var pos in slider.Path.CalculatedPath)
             {
                 minX = MathF.Min(minX, pos.X);
                 maxX = MathF.Max(maxX, pos.X);

osu.Game.Tests/Visual/Gameplay/TestSceneBezierConverter.cs

@@ -82,11 +82,7 @@ protected override void Update()
         {
             base.Update();
 
-            List<Vector2> vertices = new List<Vector2>();
-
-            path.GetPathToProgress(vertices, 0, 1);
-
-            drawablePath.Vertices = vertices;
+            drawablePath.Vertices = path.CalculatedPath;
             controlPointDrawablePath.Vertices = path.ControlPoints.Select(o => o.Position).ToList();
 
             if (controlPointDrawablePath.Vertices.Count > 0)
@@ -95,11 +91,7 @@ protected override void Update()
                     drawablePath.PositionInBoundingBox(drawablePath.Vertices[0]) - controlPointDrawablePath.PositionInBoundingBox(controlPointDrawablePath.Vertices[0]);
             }
 
-            vertices.Clear();
-
-            convertedPath.GetPathToProgress(vertices, 0, 1);
-
-            convertedDrawablePath.Vertices = vertices;
+            convertedDrawablePath.Vertices = convertedPath.CalculatedPath;
             convertedControlPointDrawablePath.Vertices = convertedPath.ControlPoints.Select(o => o.Position).ToList();
 
             if (convertedControlPointDrawablePath.Vertices.Count > 0)

osu.Game.Tests/Visual/Gameplay/TestSceneSliderPath.cs

@@ -39,12 +39,7 @@ protected override void Update()
             base.Update();
 
             if (path != null)
-            {
-                List<Vector2> vertices = new List<Vector2>();
-                path.GetPathToProgress(vertices, 0, 1);
-
-                drawablePath.Vertices = vertices;
-            }
+                drawablePath.Vertices = path.CalculatedPath;
         }
 
         [Test]

osu.Game/Rulesets/Objects/SliderPath.cs

@@ -137,6 +137,18 @@ public double CalculatedDistance
             }
         }
 
+        /// <summary>
+        /// Path vertices after lengthening/shortening to account for <see cref="ExpectedDistance"/>.
+        /// </summary>
+        public IReadOnlyList<Vector2> CalculatedPath
+        {
+            get
+            {
+                ensureValid();
+                return calculatedPath;
+            }
+        }
+
         private bool optimiseCatmull;
 
         /// <summary>