Merge pull request #192 from winnerspiros/fix/android-net10-signing-regressions-v2-1072345181990922947

fix(android): resolve INSTALL_PARSE_FAILED_NO_CERTIFICATES in .NET 10

Author: winnerspiros

.github/workflows/release.yml

@@ -98,7 +98,7 @@ jobs:
             -p:Version="${{ steps.version.outputs.version }}" \
             -p:ApplicationDisplayVersion="${{ steps.version.outputs.version }}" \
             -p:ApplicationVersion="${{ github.run_number }}" \
-            -p:AndroidKeyStore=true \
+            -p:AndroidKeyStore="true" \
             -p:AndroidSigningKeyStore="${{ github.workspace }}/osu.Android/osu.keystore" \
             -p:AndroidSigningKeyAlias="${{ secrets.ANDROID_SIGNING_KEY_ALIAS }}" \
             -p:AndroidSigningKeyPass="${{ secrets.ANDROID_SIGNING_KEY_PASSWORD }}" \
@@ -113,7 +113,7 @@ jobs:
             -p:Version="${{ steps.version.outputs.version }}" \
             -p:ApplicationDisplayVersion="${{ steps.version.outputs.version }}" \
             -p:ApplicationVersion="${{ github.run_number }}" \
-            -p:AndroidKeyStore=false
+            -p:AndroidKeyStore="false"
 
       - name: Find APK
         id: find_apk

build/PatchElfPageSize.targets

@@ -5,23 +5,21 @@
     <AndroidPackageFormat>apk</AndroidPackageFormat>
     <MandroidI18n>CJK;Mideast;Rare;West;Other;</MandroidI18n>
     <AndroidHttpClientHandlerType>Xamarin.Android.Net.AndroidMessageHandler</AndroidHttpClientHandlerType>
-    <!-- NullabilityInfoContextSupport is disabled by default for Android -->
     <NullabilityInfoContextSupport>true</NullabilityInfoContextSupport>
     <EmbedAssembliesIntoApk>true</EmbedAssembliesIntoApk>
+
+    <!-- Suppress XA1006 warning (TargetFrameworkVersion vs targetSdkVersion) -->
+    <NoWarn>$(NoWarn);XA1006</NoWarn>
+    <MSBuildWarningsAsMessages>$(MSBuildWarningsAsMessages);XA1006</MSBuildWarningsAsMessages>
+
     <!-- Suppress XA0141 page-size warnings during build. The actual .so files are patched
          to 16 KB alignment by build/PatchElfPageSize.targets, but the SDK check runs before
          the patch in some build orderings. This suppression is harmless since we do fix them. -->
     <AndroidPageSize16KBCompatibilityCheck>false</AndroidPageSize16KBCompatibilityCheck>
   </PropertyGroup>
 
-  <!-- Patch NuGet-provided .so files that ship with 4 KB ELF alignment to 16 KB.
-       See build/PatchElfPageSize.targets for details.
-       TODO: Remove once ppy.Veldrid.SPIRV ships 16 KB-aligned native libraries. -->
   <Import Project="$(MSBuildThisFileDirectory)build\PatchElfPageSize.targets" />
 
-  <!-- Release-only optimisations: AOT for low-latency gameplay, trimming for smaller APK.
-       Suppress trim analysis warnings because the project uses reflection extensively
-       (Newtonsoft.Json, Realm, AutoMapper, RuntimeBinder). -->
   <PropertyGroup Condition="'$(Configuration)' == 'Release'">
     <RunAOTCompilation>true</RunAOTCompilation>
     <AndroidEnableProfiledAot>true</AndroidEnableProfiledAot>
@@ -32,30 +30,18 @@
   </PropertyGroup>
 
   <ItemGroup Condition="'$(Configuration)' == 'Release'">
-    <!-- Force Microsoft.CSharp into the trimmer input graph (.NET 10+).          -->
-    <!-- A bare TrimmerRootAssembly is ignored if the assembly is not in the      -->
-    <!-- linker's input set; adding this reference ensures it is included.       -->
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" NoWarn="NU1510" />
     <TrimmerRootAssembly Include="Microsoft.CSharp" RootMode="all" />
   </ItemGroup>
 
   <ItemGroup>
-    <!-- IMPORTANT: ppy.osu.Framework.Android v2026.318.0 only ships net8.0-android34.0 assets.
-         NuGet silently falls back to those assets when the app targets net10.0-android (API 36).
-         This is safe because .NET guarantees backward compatibility for loading net8.0 assemblies
-         in a net10.0 runtime, and Android API changes between 34→36 are additive.
-         TODO: Remove this comment once ppy.osu.Framework.Android ships net10.0-android assets. -->
     <PackageReference Include="ppy.osu.Framework.Android" Version="2026.318.0" />
   </ItemGroup>
 
   <PropertyGroup>
-    <!-- Fody does not handle Android build well, and warns when unchanged.
-         Since Realm objects are not declared directly in Android projects, simply disable Fody. -->
     <DisableFody>true</DisableFody>
   </PropertyGroup>
 
-  <!-- Fix for .NET 10 Android AOT misclassifying non-managed assets in runtime pack.
-       This is critical for Android 16 (API 36) which has stricter manifest/parsing rules. -->
   <Target Name="FixRuntimePackAssetTypes" AfterTargets="ResolveRuntimePackAssets;ComputeFilesToPublish">
     <ItemGroup>
       <RuntimePackAsset Update="@(RuntimePackAsset)" Condition="'%(Extension)' != '.dll'">

osu.Android.props

@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='utf-8'?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="sh.ppy.osulazer" android:installLocation="auto">
-	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="36" />
+	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="35" />
 	<application android:extractNativeLibs="true" android:allowBackup="true" android:supportsRtl="true" android:label="osu!" android:icon="@mipmap/ic_launcher" android:roundIcon="@mipmap/ic_launcher" android:largeHeap="true">
         <provider android:name="androidx.core.content.FileProvider" android:authorities="sh.ppy.osulazer.fileprovider" android:grantUriPermissions="true" android:exported="false">
             <meta-data android:name="android.support.FILE_PROVIDER_PATHS" android:resource="@xml/filepaths" />

osu.Android/AndroidManifest.xml

@@ -47,6 +47,10 @@ namespace osu.Android
     [IntentFilter(new[] { Intent.ActionView }, Categories = new[] { Intent.CategoryBrowsable, Intent.CategoryDefault }, DataSchemes = new[] { "osu", "osump" })]
     public class OsuGameActivity : AndroidGameActivity, ISurfaceHolderCallback
     {
+        protected OsuGameActivity(IntPtr handle, JniHandleOwnership transfer) : base()
+        {
+        }
+
         private static readonly string[] osu_url_schemes = { "osu", "osump" };
 
         public ScreenOrientation DefaultOrientation = ScreenOrientation.Unspecified;

osu.Android/OsuGameActivity.cs

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- using a different name because package name cannot contain 'catch' -->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="osu.Game.Rulesets.Catch_Tests.Android" android:installLocation="auto">
-	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="36" />
-	<application android:allowBackup="true" android:supportsRtl="true" android:label="osu!catch Test" />
+	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="35" />
+	<application android:extractNativeLibs="true" android:allowBackup="true" android:supportsRtl="true" android:label="osu!catch Test" />
 </manifest>

osu.Game.Rulesets.Catch.Tests.Android/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="osu.Game.Rulesets.Mania.Tests.Android" android:installLocation="auto">
-	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="36" />
-	<application android:allowBackup="true" android:supportsRtl="true" android:label="osu!mania Test" />
+	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="35" />
+	<application android:extractNativeLibs="true" android:allowBackup="true" android:supportsRtl="true" android:label="osu!mania Test" />
 </manifest>

osu.Game.Rulesets.Mania.Tests.Android/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="osu.Game.Rulesets.Osu.Tests.Android" android:installLocation="auto">
-	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="36" />
-	<application android:allowBackup="true" android:supportsRtl="true" android:label="osu!standard Test" />
+	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="35" />
+	<application android:extractNativeLibs="true" android:allowBackup="true" android:supportsRtl="true" android:label="osu!standard Test" />
 </manifest>

osu.Game.Rulesets.Osu.Tests.Android/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="osu.Game.Rulesets.Taiko.Tests.Android" android:installLocation="auto">
-	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="36" />
-	<application android:allowBackup="true" android:supportsRtl="true" android:label="osu!taiko Test" />
+	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="35" />
+	<application android:extractNativeLibs="true" android:allowBackup="true" android:supportsRtl="true" android:label="osu!taiko Test" />
 </manifest>

osu.Game.Rulesets.Taiko.Tests.Android/AndroidManifest.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android" android:versionCode="1" android:versionName="1.0" package="osu.Game.Tests.Android" android:installLocation="auto">
-	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="36" />
-	<application android:allowBackup="true" android:supportsRtl="true" android:label="osu!visual Test" />
+	<uses-sdk android:minSdkVersion="33" android:targetSdkVersion="35" />
+	<application android:extractNativeLibs="true" android:allowBackup="true" android:supportsRtl="true" android:label="osu!visual Test" />
 </manifest>