fix: address InspectCode CI errors, warnings, and notes

- Remove redundant `using System.Linq;` from MainMenuButton.cs (error)
- Replace `System.Numerics.Vector2` with `Vector2` in 9 files with redundant qualifiers (warnings)
- Fix null-conditional on non-nullable `existingRoom` in LoungeSubScreen.cs (warning)
- Fix ternary line break formatting in DailyChallenge.cs (warning)
- Remove redundant type args from nameof() in SettingsItem, DrawableScrollingRuleset, RulesetInputManager (notes)
- Use `with` expression for struct copying in LinedPositionSnapGrid, RectangularPositionSnapGrid, MetronomeDisplay, TabletSettings, TabletAreaSelection, WikiPanelContainer, ModIcon, ConvertHitObject (notes)
- Use `field` keyword for backing fields in PathControlPoint, DrawableRuleset, Nub, ProgressNotification, OverlayRulesetTabItem, OverlayTabControl, ProfileItemContainer, ModFlashlight (notes)

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/d2df9e0a-0c4e-428c-99df-6ab89eefe5e7

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game/Graphics/UserInterface/Nub.cs

@@ -125,14 +125,12 @@ public Colour4 AccentColour
             }
         }
 
-        private Colour4 glowingAccentColour;
-
         public Colour4 GlowingAccentColour
         {
-            get => glowingAccentColour;
+            get;
             set
             {
-                glowingAccentColour = value;
+                field = value;
                 if (Glowing)
                     main.Colour = value;
             }

osu.Game/Overlays/Notifications/ProgressNotification.cs

@@ -47,15 +47,13 @@ public partial class ProgressNotification : Notification, IHasCompletionTarget
         /// </summary>
         public Func<bool>? CompletionClickAction { get; set; }
 
-        private LocalisableString text;
-
         public override LocalisableString Text
         {
-            get => text;
+            get;
             set
             {
-                text = value;
-                Scheduler.AddOnce(t => textDrawable.Text = t, text);
+                field = value;
+                Scheduler.AddOnce(t => textDrawable.Text = t, field);
             }
         }
 

osu.Game/Overlays/OverlayRulesetTabItem.cs

@@ -19,14 +19,12 @@ namespace osu.Game.Overlays
 {
     public partial class OverlayRulesetTabItem : TabItem<RulesetInfo>, IHasTooltip
     {
-        private Colour4 accentColour;
-
         protected virtual Colour4 AccentColour
         {
-            get => accentColour;
+            get;
             set
             {
-                accentColour = value;
+                field = value;
                 icon.FadeColour(value, 120, Easing.OutQuint);
             }
         }

osu.Game/Overlays/OverlayTabControl.cs

@@ -64,17 +64,15 @@ protected partial class OverlayTabItem : TabItem<T>, IHasAccentColour
             protected readonly ExpandingBar Bar;
             protected readonly OsuSpriteText Text;
 
-            private Colour4 accentColour;
-
             public Colour4 AccentColour
             {
-                get => accentColour;
+                get;
                 set
                 {
-                    if (accentColour == value)
+                    if (field == value)
                         return;
 
-                    accentColour = value;
+                    field = value;
                     Bar.Colour = value;
 
                     updateState();

osu.Game/Overlays/Profile/Sections/ProfileItemContainer.cs

@@ -18,26 +18,22 @@ public partial class ProfileItemContainer : Container
         private readonly Box background;
         private readonly Container content;
 
-        private Colour4 idleColour;
-
         protected Colour4 IdleColour
         {
-            get => idleColour;
+            get;
             set
             {
-                idleColour = value;
+                field = value;
                 fadeBackgroundColour();
             }
         }
 
-        private Colour4 hoverColour;
-
         protected Colour4 HoverColour
         {
-            get => hoverColour;
+            get;
             set
             {
-                hoverColour = value;
+                field = value;
                 fadeBackgroundColour();
             }
         }

osu.Game/Overlays/Settings/Sections/Input/TabletAreaSelection.cs

@@ -204,8 +204,8 @@ private void checkBounds()
 
             var usableAreaQuad = new Quad(
                 new Vector2(-halfUsableArea.X, -halfUsableArea.Y),
-                new Vector2(halfUsableArea.X, -halfUsableArea.Y),
-                new Vector2(-halfUsableArea.X, halfUsableArea.Y),
+                halfUsableArea with { Y = -halfUsableArea.Y },
+                halfUsableArea with { X = -halfUsableArea.X },
                 new Vector2(halfUsableArea.X, halfUsableArea.Y)
             );
 

osu.Game/Overlays/Settings/Sections/Input/TabletSettings.cs

@@ -205,8 +205,8 @@ protected override void LoadComplete()
                 offsetY.Value = val.NewValue.Y;
             }), true);
 
-            offsetX.BindValueChanged(val => areaOffset.Value = new Vector2(val.NewValue, areaOffset.Value.Y));
-            offsetY.BindValueChanged(val => areaOffset.Value = new Vector2(areaOffset.Value.X, val.NewValue));
+            offsetX.BindValueChanged(val => areaOffset.Value = areaOffset.Value with { X = val.NewValue });
+            offsetY.BindValueChanged(val => areaOffset.Value = areaOffset.Value with { Y = val.NewValue });
 
             areaSize.BindTo(tabletHandler.AreaSize);
             areaSize.BindValueChanged(val => Schedule(() =>
@@ -220,15 +220,15 @@ protected override void LoadComplete()
 
             sizeX.BindValueChanged(val =>
             {
-                areaSize.Value = new Vector2(val.NewValue, areaSize.Value.Y);
+                areaSize.Value = areaSize.Value with { X = val.NewValue };
 
                 aspectRatioApplication?.Cancel();
                 aspectRatioApplication = Schedule(() => applyAspectRatio(sizeX));
             });
 
             sizeY.BindValueChanged(val =>
             {
-                areaSize.Value = new Vector2(areaSize.Value.X, val.NewValue);
+                areaSize.Value = areaSize.Value with { Y = val.NewValue };
 
                 aspectRatioApplication?.Cancel();
                 aspectRatioApplication = Schedule(() => applyAspectRatio(sizeY));

osu.Game/Overlays/Settings/SettingsItem.cs

@@ -212,7 +212,7 @@ protected SettingsItem()
             // IMPORTANT: all bindable logic is in constructor intentionally to support "CreateSettingsControls" being used in a context it is
             // never loaded, but requires bindable storage.
             if (controlWithCurrent == null)
-                throw new ArgumentException(@$"Control created via {nameof(CreateControl)} must implement {nameof(IHasCurrentValue<T>)}");
+                throw new ArgumentException(@$"Control created via {nameof(CreateControl)} must implement {nameof(IHasCurrentValue<>)}");
 
             controlWithCurrent.Current.ValueChanged += _ => SettingChanged?.Invoke();
             controlWithCurrent.Current.DisabledChanged += _ => updateDisabled();

osu.Game/Overlays/Wiki/WikiPanelContainer.cs

@@ -64,7 +64,7 @@ private void load(IAPIProvider api)
         protected override void Update()
         {
             base.Update();
-            background.Size = Parent!.DrawSize * new Vector2(Size.X, 1);
+            background.Size = Parent!.DrawSize * (Size with { Y = 1 });
         }
 
         private partial class PanelBackground : CompositeDrawable

osu.Game/Rulesets/Mods/ModFlashlight.cs

@@ -180,30 +180,26 @@ protected virtual float GetComboScaleFor(int combo)
                 return 1.0f;
             }
 
-            private Vector2 flashlightPosition;
-
             protected Vector2 FlashlightPosition
             {
-                get => flashlightPosition;
+                get;
                 set
                 {
-                    if (flashlightPosition == value) return;
+                    if (field == value) return;
 
-                    flashlightPosition = value;
+                    field = value;
                     Invalidate(Invalidation.DrawNode);
                 }
             }
 
-            private Vector2 flashlightSize;
-
             protected Vector2 FlashlightSize
             {
-                get => flashlightSize;
+                get;
                 set
                 {
-                    if (flashlightSize == value) return;
+                    if (field == value) return;
 
-                    flashlightSize = value;
+                    field = value;
                     Invalidate(Invalidation.DrawNode);
                 }
             }