Skip to content

Commit d16ad3d

Browse files
Fix CI: brace block around Key.Space switch case after upstream merge + README note
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/46b5e755-967f-4136-b92d-96697f1ecd3b Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 parent 3db4639 commit d16ad3d

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ This fork includes several crash fixes on top of upstream:
188188
- **Graceful native library loading** — if the Oboe or Vulkan native libraries are missing, the app continues without them instead of crashing
189189
- **JNI surface safety** — proper lifecycle management with atomic swaps and timeouts to prevent race conditions between Android surface creation and destruction
190190
- **Trimmer-safe builds** — critical reflection-heavy assemblies are protected from .NET IL trimming to prevent `TypeLoadException` crashes in release builds
191+
- **Architecture-correct native libraries (v144+)**`osu.Android.props` now strips desktop runtime `.so` files (`runtimes/{linux,osx,ios,maccatalyst,win,…}-*/native/`) from the Android publish set, and only marks Android-RID assets as `AssetType=native`. Previous releases accidentally packaged the Linux-glibc `libbass.so` (from `ppy.osu.Framework.NativeLibs`) into `lib/arm64-v8a/`, replacing the proper Android arm64 binary; bionic's loader rejected the glibc-versioned symbols and the app crashed at startup with `System.DllNotFoundException: bass`. The release workflow now scans every shipped `libbass*.so` for `GLIBC_*` versioned symbols and fails the build if any are found, so the regression cannot recur silently.
191192

192193
---
193194

osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/PlayerHandOfCards.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ protected override bool OnKeyDown(KeyDownEvent e)
165165
}
166166

167167
case Key.Space:
168+
{
168169
if (SelectionMode == HandSelectionMode.Disabled)
169170
return false;
170171

0 commit comments

Comments
 (0)