Merge pull request #325 from winnerspiros/copilot/fix-last-build-failure-d23bcc57-97a8-45cb-9ccc-d69da72f8084

fix(android): remove uncompilable JNI activation constructor from OsuGameActivity

Author: winnerspiros

osu.Android/OsuGameActivity.cs

@@ -98,8 +98,12 @@ protected override osu.Framework.Game CreateGame()
         // The explicit SDL3-CS attribute roots SDLActivity(IntPtr, JniHandleOwnership) — the actual
         // overload TypeManager.Activate calls — which has NO managed call-graph path and would
         // otherwise be silently trimmed even if the parameterless constructor chain is preserved.
-        // See also the OsuGameActivity(IntPtr, JniHandleOwnership) constructor below, which is the
-        // direct fix for the v2026.509.229 crash: TypeManager.Activate needs this on the concrete type.
+        // NOTE: A (IntPtr, JniHandleOwnership) constructor on OsuGameActivity itself is intentionally
+        // omitted: AndroidGameActivity (C# class in osu.Framework.Android) does not declare this
+        // constructor, so calling base(javaReference, transfer) would fail to compile. TypeManager
+        // activates Activities via the parameterless constructor path in .NET Android; the actual
+        // cause of the v2026.509.229 crash was base-class constructor trimming, which is prevented
+        // by AndroidLinkSkip + the [DynamicDependency] attributes below.
         [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors,
             "osu.Framework.Android.AndroidGameActivity", "osu.Framework.Android")]
         [DynamicDependency(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors,
@@ -109,19 +113,6 @@ public OsuGameActivity()
             game = new OsuGameAndroid(this);
         }
 
-        // Required JNI activation constructor. TypeManager.Activate performs a reflection
-        // lookup for (IntPtr, JniHandleOwnership) on the *concrete* managed type when Android
-        // re-instantiates this Activity from a JNI handle (process death/recreation, back-stack
-        // restore). Inheriting this constructor from AndroidGameActivity/SDLActivity is not
-        // sufficient — .NET Android's TypeManager resolves it via GetConstructor on the concrete
-        // type; if the method is absent there the lookup falls through and Activate throws
-        // NotSupportedException ("Could not activate JNI Handle ... as managed type
-        // 'osu.Android.OsuGameActivity'"), which is the crash seen in v2026.509.229.
-        protected OsuGameActivity(IntPtr javaReference, JniHandleOwnership transfer)
-            : base(javaReference, transfer)
-        {
-        }
-
         protected override void OnCreate(Bundle? savedInstanceState)
         {
             // NOTE: do NOT assign RequestedOrientation here. The `[Activity]` attribute on this