fix: merge ppy upstream, fix iOS build error, fix trimming/AOT warnings

- Merge ppy/osu commit 45234b5 (add beatmap difficulty before mods as
  context for score multiplier calculations)
- Fix iOS build error: remove ServerGarbageCollection/ConcurrentGarbageCollection
  from iOS dotnet publish step (not supported by .NET for iOS)
- Add [DynamicallyAccessedMembers] annotations to SettingSourceAttribute:
  declaringType param, SettingControlType property
- Add [RequiresUnreferencedCode] to SettingSourceAttribute extension methods:
  CreateSettingsControls, GetSettingsSourceProperties,
  GetOrderedSettingsSourceProperties, GetUnderlyingSettingValue
- Add [RequiresUnreferencedCode] to BindableValueAccessor.GetValue/SetValue
- Add [RequiresUnreferencedCode] to SnakeCaseKeyContractResolver class
- Fix Assembly.Location → AppContext.BaseDirectory in Icons.cs,
  MacOSAppLocationChecker.cs, WindowsAssociationManager.cs
- Add [RequiresUnreferencedCode] to LegacyTcpIpcProvider class
- Add [RequiresUnreferencedCode] to DiscordRichPresence class
- Add [RequiresAssemblyFiles] to WindowsKey.Disable()
- Add #pragma warning disable IL2026 around AsQueryable() in
  DatabasedKeyBindingContainer.LoadComplete()
- Add [RequiresUnreferencedCode] to BackgroundDataStoreProcessor
  processScoresWithMissingStatistics() and LoadComplete()

Author: Copilot

.github/workflows/release.yml

@@ -598,8 +598,6 @@ jobs:
           -p:BuildIpa=false
           -p:CodesignKey=""
           -p:CodesignProvision=""
-          -p:ServerGarbageCollection=true
-          -p:ConcurrentGarbageCollection=true
 
       - name: Package iOS build
         run: |

osu.Desktop/DiscordRichPresence.cs

@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Text;
 using DiscordRPC;
 using DiscordRPC.Message;
@@ -27,6 +28,7 @@
 
 namespace osu.Desktop
 {
+    [RequiresUnreferencedCode("Newtonsoft.Json relies on reflection over types that may be removed when trimming.")]
     internal partial class DiscordRichPresence : Component
     {
         private const string client_id = "1216669957799018608";

osu.Desktop/LegacyIpc/LegacyTcpIpcProvider.cs

@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Newtonsoft.Json.Linq;
 using osu.Framework.Logging;
@@ -20,6 +21,7 @@ namespace osu.Desktop.LegacyIpc
     /// <summary>
     /// Provides IPC to legacy osu! clients.
     /// </summary>
+    [RequiresUnreferencedCode("Newtonsoft.Json relies on reflection over types that may be removed when trimming.")]
     public class LegacyTcpIpcProvider : TcpIpcProvider
     {
         private static readonly Logger logger = Logger.GetLogger("legacy-ipc");

osu.Desktop/MacOS/MacOSAppLocationChecker.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.IO;
-using osu.Framework;
 using osu.Framework.Allocation;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Sprites;
@@ -26,7 +25,7 @@ protected override void LoadComplete()
         {
             base.LoadComplete();
 
-            string assemblyPath = RuntimeInfo.EntryAssembly.Location;
+            string assemblyPath = AppContext.BaseDirectory;
 
             bool inRootApp = assemblyPath.StartsWith("/Applications/", StringComparison.Ordinal);
             bool inUserApp = assemblyPath.StartsWith(Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), "Applications/"), StringComparison.Ordinal);

osu.Desktop/Windows/Icons.cs

@@ -1,6 +1,7 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System;
 using System.IO;
 
 namespace osu.Desktop.Windows
@@ -10,7 +11,7 @@ public static class Icons
         /// <summary>
         /// Fully qualified path to the directory that contains icons (in the installation folder).
         /// </summary>
-        private static readonly string icon_directory = Path.GetDirectoryName(typeof(Icons).Assembly.Location)!;
+        private static readonly string icon_directory = AppContext.BaseDirectory;
 
         public static string Lazer => Path.Join(icon_directory, "lazer.ico");
 

osu.Desktop/Windows/WindowsAssociationManager.cs

@@ -31,7 +31,7 @@ public static class WindowsAssociationManager
         /// </summary>
         internal const string SHELL_OPEN_COMMAND = @"Shell\Open\Command";
 
-        private static readonly string exe_path = Path.ChangeExtension(typeof(WindowsAssociationManager).Assembly.Location, ".exe").Replace('/', '\\');
+        private static readonly string exe_path = Path.Combine(AppContext.BaseDirectory, Path.ChangeExtension(AppDomain.CurrentDomain.FriendlyName, ".exe")).Replace('/', '\\');
 
         /// <summary>
         /// Program ID prefix used for file associations. Should be relatively short since the full program ID has a 39 character limit,

osu.Desktop/Windows/WindowsKey.cs

@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
 
 // ReSharper disable IdentifierTypo
@@ -47,6 +48,7 @@ private static int lowLevelKeyboardProc(int nCode, int wParam, ref KdDllHookStru
             return callNextHookEx(0, nCode, wParam, ref lParam);
         }
 
+        [RequiresAssemblyFiles("Uses Marshal.GetHINSTANCE which requires the assembly to be loaded from disk.")]
         internal static void Disable()
         {
             if (keyHook != IntPtr.Zero || isBlocked)

osu.Game/Configuration/SettingSourceAttribute.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Reflection;
 using JetBrains.Annotations;
@@ -42,9 +43,10 @@ public class SettingSourceAttribute : Attribute, IComparable<SettingSourceAttrib
         /// <remarks>
         /// Must be a type deriving <see cref="SettingsItem{T}"/> with a public parameterless constructor.
         /// </remarks>
+        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)]
         public Type? SettingControlType { get; set; }
 
-        public SettingSourceAttribute(Type declaringType, string label, string? description = null)
+        public SettingSourceAttribute([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type declaringType, string label, string? description = null)
         {
             Label = getLocalisableStringFromMember(label) ?? string.Empty;
             Description = getLocalisableStringFromMember(description) ?? string.Empty;
@@ -109,6 +111,7 @@ public int CompareTo(SettingSourceAttribute? other)
 
     public static partial class SettingSourceExtensions
     {
+        [RequiresUnreferencedCode("SettingSourceAttribute uses reflection to instantiate settings controls and may not be compatible with trimming.")]
         public static IEnumerable<Drawable> CreateSettingsControls(this object obj)
         {
             foreach (var (attr, property) in obj.GetOrderedSettingsSourceProperties())
@@ -222,6 +225,7 @@ public static IEnumerable<Drawable> CreateSettingsControls(this object obj)
         /// Can be used for serialization and equality comparison purposes.
         /// </summary>
         /// <param name="setting">A <see cref="SettingSourceAttribute"/> bindable.</param>
+        [RequiresUnreferencedCode("Uses BindableValueAccessor which relies on reflection and may not be compatible with trimming.")]
         public static object GetUnderlyingSettingValue(this object setting)
         {
             switch (setting)
@@ -250,6 +254,7 @@ public static object GetUnderlyingSettingValue(this object setting)
             }
         }
 
+        [RequiresUnreferencedCode("SettingSourceAttribute uses reflection to retrieve properties and may not be compatible with trimming.")]
         public static IEnumerable<(SettingSourceAttribute, PropertyInfo)> GetSettingsSourceProperties(this object obj)
         {
             var type = obj.GetType();
@@ -260,7 +265,7 @@ public static object GetUnderlyingSettingValue(this object setting)
             return properties;
         }
 
-        private static IEnumerable<(SettingSourceAttribute, PropertyInfo)> getSettingsSourceProperties(Type type)
+        private static IEnumerable<(SettingSourceAttribute, PropertyInfo)> getSettingsSourceProperties([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] Type type)
         {
             foreach (var property in type.GetProperties(BindingFlags.GetProperty | BindingFlags.Public | BindingFlags.Instance))
             {
@@ -273,6 +278,7 @@ public static object GetUnderlyingSettingValue(this object setting)
             }
         }
 
+        [RequiresUnreferencedCode("SettingSourceAttribute uses reflection to retrieve properties and may not be compatible with trimming.")]
         public static ICollection<(SettingSourceAttribute, PropertyInfo)> GetOrderedSettingsSourceProperties(this object obj)
             => obj.GetSettingsSourceProperties()
                   .OrderBy(attr => attr.Item1)

osu.Game/Database/BackgroundDataStoreProcessor.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
 using System.Threading;
@@ -77,8 +78,8 @@ public partial class BackgroundDataStoreProcessor : Component
 
         protected virtual int TimeToSleepDuringGameplay => 30000;
 
-        protected override void LoadComplete()
-        {
+        [RequiresUnreferencedCode("Calls processScoresWithMissingStatistics which uses Newtonsoft.Json reflection.")]
+        protected override void LoadComplete()        {
             base.LoadComplete();
 
             localMetadataSource = new LocalCachedBeatmapMetadataSource(storage);
@@ -345,6 +346,7 @@ private void processBeatmapsWithMissingObjectCounts()
             completeNotification(notification, processedCount, beatmapIds.Count, failedCount);
         }
 
+        [RequiresUnreferencedCode("Newtonsoft.Json relies on reflection over types that may be removed when trimming.")]
         private void processScoresWithMissingStatistics()
         {
             HashSet<Guid> scoreIds = new HashSet<Guid>();

osu.Game/IO/Serialization/SnakeCaseKeyContractResolver.cs

@@ -1,11 +1,13 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System.Diagnostics.CodeAnalysis;
 using Newtonsoft.Json.Serialization;
 using osu.Game.Extensions;
 
 namespace osu.Game.IO.Serialization
 {
+    [RequiresUnreferencedCode("Newtonsoft.Json relies on reflection over types that may be removed when trimming.")]
     public class SnakeCaseKeyContractResolver : DefaultContractResolver
     {
         protected override string ResolvePropertyName(string propertyName)