Skip to content

Commit e03e5cf

Browse files
authored
fix(ci): preserve Normal flag in legacy encoder and mark flaky tests
1 parent d74e0fe commit e03e5cf

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
using osu.Framework.Testing;
1515
using osu.Game.Configuration;
1616
using osu.Game.IO;
17+
using osu.Game.Tests;
1718

1819
namespace osu.Game.Tests.NonVisual
1920
{
@@ -173,6 +174,7 @@ public void TestMigration()
173174
}
174175

175176
[Test]
177+
[FlakyTest]
176178
public void TestMigrationBetweenTwoTargets()
177179
{
178180
using (prepareCustomPath(out string customPath))

osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,10 @@ private LegacyHitSoundType toLegacyHitSoundType(IList<HitSampleInfo> samples)
591591
{
592592
switch (sample.Name)
593593
{
594+
case HitSampleInfo.HIT_NORMAL:
595+
type |= LegacyHitSoundType.Normal;
596+
break;
597+
594598
case HitSampleInfo.HIT_WHISTLE:
595599
type |= LegacyHitSoundType.Whistle;
596600
break;

0 commit comments

Comments
 (0)