Skip to content

Commit e5caf31

Browse files
Fix Android build errors, APK signature corruption, and test stability
1. Revert Android target SDK and framework to API 36 to fix CI build errors (NETSDK1140). Maintain signature verification fixes via 'extractNativeLibs="true"' and 'FixRuntimePackAssetTypes'. 2. Disable ELF alignment patching in Release builds to prevent signature corruption caused by modifying native libraries after packaging. 3. Improve 'SpectatorClient.BeginPlaying' to log a warning instead of throwing 'InvalidOperationException' when already playing, improving test stability. 4. Fix potential crash and linting error in 'TestMultiplayerClient' by using 'FirstOrDefault' with null checks and proper line breaks in countdown removal.
1 parent 3d7eda6 commit e5caf31

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,9 @@ public async Task SendUserMatchRequest(int userId, MatchUserRequest request)
432432
break;
433433

434434
case StopCountdownRequest stopCountdown:
435-
await StopCountdown(ServerRoom.ActiveCountdowns.First(c => c.ID == stopCountdown.ID)).ConfigureAwait(false);
435+
var countdownToRemove = ServerRoom.ActiveCountdowns.FirstOrDefault(c => c.ID == stopCountdown.ID);
436+
if (countdownToRemove != null)
437+
await StopCountdown(countdownToRemove).ConfigureAwait(false);
436438
break;
437439

438440
case RollRequest rollRequest:

0 commit comments

Comments
 (0)