fix: resolve all InspectCode warnings and notes from CI

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/25d444f7-30e4-4b5b-b6b2-23759a4fee69

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game.Rulesets.Catch/Skinning/Default/BananaPulpFormation.cs

@@ -1,7 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
-
 using System.Numerics;
 
 namespace osu.Game.Rulesets.Catch.Skinning.Default

osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyColumnBackground.cs

@@ -35,7 +35,7 @@ private void load(ISkinSource skin, IScrollingInfo scrollingInfo)
                                   ?? 0;
 
             Colour4 lightColour = GetColumnSkinConfig<Colour4>(skin, LegacyManiaSkinConfigurationLookups.ColumnLightColour)?.Value
-                                 ?? Colour4.White;
+                                  ?? Colour4.White;
 
             int lightFramePerSecond = skin.GetManiaSkinConfig<int>(LegacyManiaSkinConfigurationLookups.LightFramePerSecond)?.Value ?? 60;
 

osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyHitTarget.cs

@@ -29,7 +29,7 @@ private void load(ISkinSource skin, IScrollingInfo scrollingInfo)
                                      ?? true;
 
             Colour4 lineColour = skin.GetManiaSkinConfig<Colour4>(LegacyManiaSkinConfigurationLookups.JudgementLineColour)?.Value
-                                ?? Colour4.White;
+                                 ?? Colour4.White;
 
             InternalChild = directionContainer = new Container
             {

osu.Game.Rulesets.Osu/Utils/OsuHitObjectGenerationUtils.cs

@@ -132,7 +132,7 @@ public static void ReflectVerticallyAlongPlayfield(OsuHitObject osuObject)
             if (osuObject is not Slider slider)
                 return;
 
-            static void reflectControlPoint(PathControlPoint point) => point.Position = new Vector2(point.Position.X, -point.Position.Y);
+            static void reflectControlPoint(PathControlPoint point) => point.Position = point.Position with { Y = -point.Position.Y };
 
             modifySlider(slider, reflectControlPoint);
         }
@@ -143,7 +143,7 @@ public static void ReflectVerticallyAlongPlayfield(OsuHitObject osuObject)
         /// <param name="slider">The slider to be flipped.</param>
         public static void FlipSliderInPlaceHorizontally(Slider slider)
         {
-            static void flipControlPoint(PathControlPoint point) => point.Position = new Vector2(-point.Position.X, point.Position.Y);
+            static void flipControlPoint(PathControlPoint point) => point.Position = point.Position with { X = -point.Position.X };
 
             modifySlider(slider, flipControlPoint);
         }

osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs

@@ -710,7 +710,7 @@ public void TestInvalidEventStillPasses()
             using (var badResStream = TestResources.OpenResource("invalid-events.osu"))
             using (var badStream = new LineBufferedReader(badResStream))
             {
-                Assert.DoesNotThrow(() => decoder.Decode(badStream));
+                decoder.Decode(badStream);
             }
         }
 
@@ -755,9 +755,9 @@ public void TestFallbackDecoderForCorruptedHeader()
             using (var resStream = TestResources.OpenResource("corrupted-header.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyBeatmapDecoder>(decoder);
-                Assert.DoesNotThrow(() => beatmap = decoder.Decode(stream));
+                beatmap = decoder.Decode(stream);
                 ClassicAssert.NotNull(beatmap);
                 ClassicAssert.AreEqual("Beatmap with corrupted header", beatmap.Metadata.Title);
                 ClassicAssert.AreEqual("Evil Hacker", beatmap.Metadata.Author.Username);
@@ -773,9 +773,9 @@ public void TestFallbackDecoderForMissingHeader()
             using (var resStream = TestResources.OpenResource("missing-header.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyBeatmapDecoder>(decoder);
-                Assert.DoesNotThrow(() => beatmap = decoder.Decode(stream));
+                beatmap = decoder.Decode(stream);
                 ClassicAssert.NotNull(beatmap);
                 ClassicAssert.AreEqual("Beatmap with no header", beatmap.Metadata.Title);
                 ClassicAssert.AreEqual("Incredibly Evil Hacker", beatmap.Metadata.Author.Username);
@@ -791,9 +791,9 @@ public void TestDecodeFileWithEmptyLinesAtStart()
             using (var resStream = TestResources.OpenResource("empty-lines-at-start.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyBeatmapDecoder>(decoder);
-                Assert.DoesNotThrow(() => beatmap = decoder.Decode(stream));
+                beatmap = decoder.Decode(stream);
                 ClassicAssert.NotNull(beatmap);
                 ClassicAssert.AreEqual("Empty lines at start", beatmap.Metadata.Title);
                 ClassicAssert.AreEqual("Edge Case Hunter", beatmap.Metadata.Author.Username);
@@ -809,9 +809,9 @@ public void TestDecodeFileWithEmptyLinesAndNoHeader()
             using (var resStream = TestResources.OpenResource("empty-line-instead-of-header.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyBeatmapDecoder>(decoder);
-                Assert.DoesNotThrow(() => beatmap = decoder.Decode(stream));
+                beatmap = decoder.Decode(stream);
                 ClassicAssert.NotNull(beatmap);
                 ClassicAssert.AreEqual("The dog ate the file header", beatmap.Metadata.Title);
                 ClassicAssert.AreEqual("Why does this keep happening", beatmap.Metadata.Author.Username);
@@ -827,9 +827,9 @@ public void TestDecodeFileWithContentImmediatelyAfterHeader()
             using (var resStream = TestResources.OpenResource("no-empty-line-after-header.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyBeatmapDecoder>(decoder);
-                Assert.DoesNotThrow(() => beatmap = decoder.Decode(stream));
+                beatmap = decoder.Decode(stream);
                 ClassicAssert.NotNull(beatmap);
                 ClassicAssert.AreEqual("No empty line delimiting header from contents", beatmap.Metadata.Title);
                 ClassicAssert.AreEqual("Edge Case Hunter", beatmap.Metadata.Author.Username);
@@ -839,11 +839,9 @@ public void TestDecodeFileWithContentImmediatelyAfterHeader()
         [Test]
         public void TestDecodeEmptyFile()
         {
-            using (var resStream = new MemoryStream())
-            using (var stream = new LineBufferedReader(resStream))
-            {
-                Assert.Throws<IOException>(() => Decoder.GetDecoder<Beatmap>(stream));
-            }
+            using var resStream = new MemoryStream();
+            using var stream = new LineBufferedReader(resStream);
+            Assert.Throws<IOException>(() => Decoder.GetDecoder<Beatmap>(stream));
         }
 
         [Test]
@@ -854,7 +852,7 @@ public void TestAllowFallbackDecoderOverwrite()
             using (var resStream = TestResources.OpenResource("corrupted-header.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyBeatmapDecoder>(decoder);
             }
 
@@ -863,7 +861,7 @@ public void TestAllowFallbackDecoderOverwrite()
             using (var resStream = TestResources.OpenResource("corrupted-header.osu"))
             using (var stream = new LineBufferedReader(resStream))
             {
-                Assert.DoesNotThrow(() => decoder = Decoder.GetDecoder<Beatmap>(stream));
+                decoder = Decoder.GetDecoder<Beatmap>(stream);
                 ClassicAssert.IsInstanceOf<LegacyDifficultyCalculatorBeatmapDecoder>(decoder);
             }
         }

osu.Game.Tests/Visual/Editing/TestSceneColoursSection.cs

@@ -45,7 +45,7 @@ public void TestNoBeatmapSkinColours()
             AddAssert("beatmap skin has no colours", () => skin.Configuration.CustomComboColours, () => Is.Empty);
             AddAssert("section displays default combo colours",
                 () => coloursSection.ChildrenOfType<FormColourPalette>().Single().Colours,
-                () => Is.EquivalentTo(new Colour4[]
+                () => Is.EquivalentTo(new[]
                 {
                     SkinConfiguration.DefaultComboColours[1],
                     SkinConfiguration.DefaultComboColours[2],

osu.Game.Tests/Visual/UserInterface/TestScenePopupDialog.cs

@@ -36,7 +36,7 @@ public void TestDangerousButton([Values(false, true)] bool atEdge)
                 AddStep("move mouse to button edge", () =>
                 {
                     var dangerousButtonQuad = dialog.DangerousButton.ScreenSpaceDrawQuad;
-                    InputManager.MoveMouseTo(new Vector2(dangerousButtonQuad.TopLeft.X + 5, dangerousButtonQuad.Centre.Y));
+                    InputManager.MoveMouseTo(dangerousButtonQuad.Centre with { X = dangerousButtonQuad.TopLeft.X + 5 });
                 });
             }
             else

osu.Game.Tournament/Screens/Drawings/Components/ScrollingTeamContainer.cs

@@ -135,7 +135,7 @@ private void setScrollState(ScrollState newState)
                             closest = stc;
                     }
 
-                    Debug.Assert(closest != null, "closest != null");
+                    Debug.Assert(closest != null);
 
                     offset += DrawWidth / 2f - (closest.Position.X + closest.DrawWidth / 2f);
 

osu.Game.Tournament/Screens/Gameplay/Components/TeamScoreDisplay.cs

@@ -23,7 +23,8 @@ public partial class TeamScoreDisplay : CompositeDrawable
 
         public bool ShowScore
         {
-            get => teamDisplay?.ShowScore ?? false; set => teamDisplay?.ShowScore = value;
+            get => teamDisplay?.ShowScore ?? false;
+            set => teamDisplay?.ShowScore = value;
         }
 
         public TeamScoreDisplay(TeamColour teamColour)

osu.Game/Graphics/Cursor/OsuTooltipContainer.cs

@@ -97,7 +97,7 @@ protected override void PopIn()
 
             protected override void PopOut() => this.Delay(150).FadeOut(300, Easing.OutQuint);
 
-            public override void Move(System.Numerics.Vector2 pos)
+            public override void Move(Vector2 pos)
             {
                 if (instantMovement)
                 {