perf: deep System.Numerics hot-path optimization pass (28 files)

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/f74b2f21-6bd8-45e8-b698-3737ddf65ed7

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game.Rulesets.Catch/Edit/Blueprints/FruitPlacementBlueprint.cs

@@ -48,7 +48,7 @@ public override SnapResult UpdateTimeAndPosition(Vector2 screenSpacePosition, do
             gridSnapResult.ScreenSpacePosition.X = screenSpacePosition.X;
             var distanceSnapResult = Composer?.TryDistanceSnap(gridSnapResult.ScreenSpacePosition);
 
-            var result = distanceSnapResult != null && Vector2.Distance(gridSnapResult.ScreenSpacePosition, distanceSnapResult.ScreenSpacePosition) < CatchHitObjectComposer.DISTANCE_SNAP_RADIUS
+            var result = distanceSnapResult != null && Vector2.DistanceSquared(gridSnapResult.ScreenSpacePosition, distanceSnapResult.ScreenSpacePosition) < CatchHitObjectComposer.DISTANCE_SNAP_RADIUS * CatchHitObjectComposer.DISTANCE_SNAP_RADIUS
                 ? distanceSnapResult
                 : gridSnapResult;
 

osu.Game.Rulesets.Catch/Edit/Blueprints/JuiceStreamPlacementBlueprint.cs

@@ -88,7 +88,7 @@ public override SnapResult UpdateTimeAndPosition(Vector2 screenSpacePosition, do
             gridSnapResult.ScreenSpacePosition.X = screenSpacePosition.X;
             var distanceSnapResult = Composer?.TryDistanceSnap(gridSnapResult.ScreenSpacePosition);
 
-            var result = distanceSnapResult != null && Vector2.Distance(gridSnapResult.ScreenSpacePosition, distanceSnapResult.ScreenSpacePosition) < CatchHitObjectComposer.DISTANCE_SNAP_RADIUS
+            var result = distanceSnapResult != null && Vector2.DistanceSquared(gridSnapResult.ScreenSpacePosition, distanceSnapResult.ScreenSpacePosition) < CatchHitObjectComposer.DISTANCE_SNAP_RADIUS * CatchHitObjectComposer.DISTANCE_SNAP_RADIUS
                 ? distanceSnapResult
                 : gridSnapResult;
 

osu.Game.Rulesets.Catch/Edit/CatchBlueprintContainer.cs

@@ -55,7 +55,7 @@ protected override bool TryMoveBlueprints(DragEvent e, IList<(SelectionBlueprint
             gridSnapResult.ScreenSpacePosition.X = movePosition.X;
             var distanceSnapResult = Composer.TryDistanceSnap(gridSnapResult.ScreenSpacePosition);
 
-            var result = distanceSnapResult != null && Vector2.Distance(gridSnapResult.ScreenSpacePosition, distanceSnapResult.ScreenSpacePosition) < CatchHitObjectComposer.DISTANCE_SNAP_RADIUS
+            var result = distanceSnapResult != null && Vector2.DistanceSquared(gridSnapResult.ScreenSpacePosition, distanceSnapResult.ScreenSpacePosition) < CatchHitObjectComposer.DISTANCE_SNAP_RADIUS * CatchHitObjectComposer.DISTANCE_SNAP_RADIUS
                 ? distanceSnapResult
                 : gridSnapResult;
 

osu.Game.Rulesets.Osu/Edit/Blueprints/GridPlacementBlueprint.cs

@@ -110,7 +110,7 @@ public override SnapResult UpdateTimeAndPosition(Vector2 screenSpacePosition, do
             else
             {
                 // Default to the original spacing and rotation if the distance is too small.
-                if (Vector2.Distance(gridToolboxGroup.StartPosition.Value, pos) < 2)
+                if (Vector2.DistanceSquared(gridToolboxGroup.StartPosition.Value, pos) < 4)
                 {
                     gridToolboxGroup.GridLineSpacing.Value = originalSpacing;
                     if (!gridToolboxGroup.GridLinesRotation.Disabled)

osu.Game.Rulesets.Osu/Edit/OsuDistanceSnapProvider.cs

@@ -19,7 +19,7 @@ public override double ReadCurrentDistanceSnap(HitObject before, HitObject after
         {
             // If the pair of hit objects in question here could feasibly be on the same stack, do not provide a distance snap value -
             // they're likely too close to one another for the distance snap value to be useful anyway even if they somehow are not.
-            if (Vector2.Distance(((OsuHitObject)before).EndPosition, ((OsuHitObject)after).Position) < OsuBeatmapProcessor.STACK_DISTANCE)
+            if (Vector2.DistanceSquared(((OsuHitObject)before).EndPosition, ((OsuHitObject)after).Position) < OsuBeatmapProcessor.STACK_DISTANCE * OsuBeatmapProcessor.STACK_DISTANCE)
                 return 0;
 
             var lastObjectWithVelocity = EditorBeatmap.HitObjects.TakeWhile(ho => ho != after).OfType<IHasSliderVelocity>().LastOrDefault();

osu.Game.Rulesets.Osu/Edit/OsuHitObjectComposer.cs

@@ -309,9 +309,9 @@ private bool snapToVisibleBlueprints(Vector2 screenSpacePosition, out SnapResult
                 if (!snapPositions.Any())
                     continue;
 
-                var closestSnapPosition = snapPositions.MinBy(p => Vector2.Distance(p, screenSpacePosition));
+                var closestSnapPosition = snapPositions.MinBy(p => Vector2.DistanceSquared(p, screenSpacePosition));
 
-                if (Vector2.Distance(closestSnapPosition, screenSpacePosition) < snapRadius)
+                if (Vector2.DistanceSquared(closestSnapPosition, screenSpacePosition) < snapRadius * snapRadius)
                 {
                     // if the snap target is a stacked object, snap to its unstacked position rather than its stacked position.
                     // this is intended to make working with stacks easier (because thanks to this, you can drag an object to any

osu.Game.Rulesets.Osu/Mods/OsuModRandom.cs

@@ -129,7 +129,7 @@ private float getRelativeTargetAngle(float targetDistance, float offset, bool fl
             float angle = (float)(2.16 / (1 + 200 * Math.Exp(0.036 * (targetDistance - 310 + customOffsetX))) + 0.5);
             angle += offset + customOffsetY;
 
-            float relativeAngle = (float)Math.PI - angle;
+            float relativeAngle = MathF.PI - angle;
 
             return flowDirection ? -relativeAngle : relativeAngle;
         }

osu.Game.Rulesets.Osu/Mods/OsuModTargetPractice.cs

@@ -450,7 +450,8 @@ private int nodeIndexFromTime(IHasRepeats curve, double timeSinceStart)
 
         private bool checkForOverlap(IEnumerable<OsuHitObject> objectsToCheck, OsuHitObject target)
         {
-            return objectsToCheck.Any(h => Vector2.Distance(h.Position, target.Position) < target.Radius * 2);
+            float radiusTwice = target.Radius * 2;
+            return objectsToCheck.Any(h => Vector2.DistanceSquared(h.Position, target.Position) < radiusTwice * radiusTwice);
         }
 
         /// <summary>

osu.Game.Rulesets.Osu/Mods/OsuModWiggle.cs

@@ -57,9 +57,9 @@ private void drawableOnApplyCustomUpdateState(DrawableHitObject drawable, ArmedS
 
             void wiggle()
             {
-                float nextAngle = (float)(objRand.NextDouble() * 2 * Math.PI);
+                float nextAngle = (float)(objRand.NextDouble() * 2) * MathF.PI;
                 float nextDist = (float)(objRand.NextDouble() * Strength.Value * 7);
-                drawable.MoveTo(new Vector2((float)(nextDist * Math.Cos(nextAngle) + origin.X), (float)(nextDist * Math.Sin(nextAngle) + origin.Y)), wiggle_duration);
+                drawable.MoveTo(new Vector2(nextDist * MathF.Cos(nextAngle) + origin.X, nextDist * MathF.Sin(nextAngle) + origin.Y), wiggle_duration);
             }
 
             for (int i = 0; i < amountWiggles; i++)

osu.Game.Rulesets.Osu/Objects/Drawables/Connections/FollowPointConnection.cs

@@ -62,7 +62,7 @@ private void scheduleRefresh() => Scheduler.AddOnce(() =>
 
             Vector2 distanceVector = endPosition - startPosition;
             int distance = (int)distanceVector.Length();
-            float rotation = (float)(Math.Atan2(distanceVector.Y, distanceVector.X) * (180 / Math.PI));
+            float rotation = MathF.Atan2(distanceVector.Y, distanceVector.X) * (180f / MathF.PI);
 
             double finalTransformEndTime = startTime;