Merge pull request #26 from winnerspiros/autopilot-spinner-fix-6744754247941515378

Fix Autopilot spinner spinning

Author: winnerspiros

osu.Game.Rulesets.Osu/Mods/OsuModAutopilot.cs

@@ -1,4 +1,4 @@
-// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
 using System;
@@ -50,13 +50,20 @@ public void Update(Playfield playfield)
             // Very naive implementation of autopilot based on proximity to replay frames.
             // Special case for the first frame is required to ensure the mouse is in a sane position until the actual time of the first frame is hit.
             // TODO: this needs to be based on user interactions to better match stable (pausing until judgement is registered).
-            if (currentFrame < 0 || Math.Abs(replayFrames[currentFrame + 1].Time - time) <= Math.Abs(replayFrames[currentFrame].Time - time))
+            while (currentFrame < replayFrames.Count - 1)
             {
-                currentFrame++;
-                new MousePositionAbsoluteInput { Position = playfield.ToScreenSpace(replayFrames[currentFrame].Position) }.Apply(inputManager.CurrentState, inputManager);
+                if (currentFrame < 0 || Math.Abs(replayFrames[currentFrame + 1].Time - time) <= Math.Abs(replayFrames[currentFrame].Time - time))
+                {
+                    currentFrame++;
+                }
+                else
+                {
+                    break;
+                }
             }
 
-            // TODO: Implement the functionality to automatically spin spinners
+            if (currentFrame >= 0)
+                new MousePositionAbsoluteInput { Position = playfield.ToScreenSpace(replayFrames[currentFrame].Position) }.Apply(inputManager.CurrentState, inputManager);
         }
 
         public void ApplyToDrawableRuleset(DrawableRuleset<OsuHitObject> drawableRuleset)

osu.Game/Database/BackgroundDataStoreProcessor.cs

@@ -10,6 +10,7 @@
 using Newtonsoft.Json;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
+using osu.Framework.Development;
 using osu.Framework.Extensions;
 using osu.Framework.Graphics;
 using osu.Framework.Logging;
@@ -622,6 +623,8 @@ private void upgradeScoreRanks()
 
         private void backpopulateMissingSubmissionAndRankDates()
         {
+            if (DebugUtils.IsNUnitRunning) return;
+
             if (!localMetadataSource.Available)
             {
                 Logger.Log("Cannot backpopulate missing submission/rank dates because the local metadata cache is missing.");
@@ -725,6 +728,8 @@ protected virtual void backpopulateUserTags()
 
             if (!localMetadataSource.Available || !localMetadataSource.IsAtLeastVersion(3))
             {
+                if (DebugUtils.IsNUnitRunning) return;
+
                 Logger.Log(@"Local metadata cache has too low version to backpopulate user tags, attempting refetch...");
                 localMetadataSource.FetchCache().WaitSafely();