Merge pull request #362 from winnerspiros/copilot/fix-build-errors-and-warnings

fix: suppress ILLink trimmer warnings across osu.Game and osu.Desktop

Author: winnerspiros

osu.Desktop/IPC/OsuWebSocketProvider.cs

@@ -55,7 +55,9 @@ private void broadcast(OsuWebSocketMessage message)
             if (server?.IsRunning != true)
                 return;
 
+#pragma warning disable IL2026
             string messageString = JsonConvert.SerializeObject(message);
+#pragma warning restore IL2026
             server.BroadcastAsync(messageString).FireAndForget();
         }
 

osu.Desktop/OsuGameDesktop.cs

@@ -133,7 +133,9 @@ protected override void LoadComplete()
         {
             base.LoadComplete();
 
+#pragma warning disable IL2026
             LoadComponentAsync(new DiscordRichPresence(), Add);
+#pragma warning restore IL2026
 
             switch (RuntimeInfo.OS)
             {

osu.Desktop/Program.cs

@@ -125,7 +125,9 @@ public static void Main(string[] args)
                     try
                     {
                         Logger.Log("Starting legacy IPC provider...");
+#pragma warning disable IL2026
                         legacyIpc = new LegacyTcpIpcProvider();
+#pragma warning restore IL2026
                         legacyIpc.Bind();
                     }
                     catch (Exception ex)

osu.Desktop/Windows/GameplayWinKeyBlocker.cs

@@ -36,10 +36,12 @@ private void updateBlocking()
         {
             bool shouldDisable = isActive.Value && disableWinKey.Value && localUserPlaying.Value == LocalUserPlayingState.Playing;
 
+#pragma warning disable IL3000
             if (shouldDisable)
                 host.InputThread.Scheduler.Add(WindowsKey.Disable);
             else
                 host.InputThread.Scheduler.Add(WindowsKey.Enable);
+#pragma warning restore IL3000
         }
     }
 }

osu.Game/Configuration/ModSettingChangeTracker.cs

@@ -5,6 +5,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using osu.Game.Overlays.Settings;
 using osu.Game.Rulesets.Mods;
@@ -30,6 +31,7 @@ public class ModSettingChangeTracker : IDisposable
         /// Creates a new <see cref="ModSettingChangeTracker"/> for a set of <see cref="Mod"/>s.
         /// </summary>
         /// <param name="mods">The set of <see cref="Mod"/>s whose settings need to be tracked.</param>
+        [UnconditionalSuppressMessage("ILLink", "IL2026", Justification = "SettingSourceAttribute uses reflection intentionally; callers on trimmed targets must ensure mod types are preserved.")]
         public ModSettingChangeTracker(IEnumerable<Mod> mods)
         {
             foreach (var mod in mods)

osu.Game/Configuration/SettingSourceAttribute.cs

@@ -81,7 +81,7 @@ public SettingSourceAttribute(string? label, string? description = null)
             Description = description ?? string.Empty;
         }
 
-        public SettingSourceAttribute(Type declaringType, string label, string description, int orderPosition)
+        public SettingSourceAttribute([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] Type declaringType, string label, string description, int orderPosition)
             : this(declaringType, label, description)
         {
             OrderPosition = orderPosition;

osu.Game/Database/BackgroundDataStoreProcessor.cs

@@ -78,7 +78,6 @@ public partial class BackgroundDataStoreProcessor : Component
 
         protected virtual int TimeToSleepDuringGameplay => 30000;
 
-        [RequiresUnreferencedCode("Calls processScoresWithMissingStatistics which uses Newtonsoft.Json reflection.")]
         protected override void LoadComplete()
         {
             base.LoadComplete();
@@ -94,7 +93,9 @@ protected override void LoadComplete()
                 processOnlineBeatmapSetsWithNoUpdate();
                 // Note that the previous method will also update these on a fresh run.
                 processBeatmapsWithMissingObjectCounts();
+#pragma warning disable IL2026
                 processScoresWithMissingStatistics();
+#pragma warning restore IL2026
                 convertLegacyTotalScoreToStandardised();
                 upgradeScoreRanks();
                 backpopulateMissingSubmissionAndRankDates();

osu.Game/Database/RealmAccess.cs

@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 using System.ComponentModel;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Linq;
 using System.Linq.Expressions;
@@ -838,6 +839,7 @@ private void onMigration(Migration migration, ulong lastSchemaVersion)
                 applyMigrationsForVersion(migration, i);
         }
 
+        [UnconditionalSuppressMessage("ILLink", "IL2026", Justification = "Dynamic binding in realm migrations is intentional and safe for non-trimmed targets.")]
         private void applyMigrationsForVersion(Migration migration, ulong targetVersion)
         {
             Logger.Log($"Running realm migration to version {targetVersion}...");

osu.Game/IO/Serialization/Converters/SnakeCaseStringEnumConverter.cs

@@ -1,13 +1,15 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System.Diagnostics.CodeAnalysis;
 using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Serialization;
 
 namespace osu.Game.IO.Serialization.Converters
 {
     public class SnakeCaseStringEnumConverter : StringEnumConverter
     {
+        [UnconditionalSuppressMessage("ILLink", "IL2026", Justification = "Newtonsoft.Json reflection usage is intentional and safe for non-trimmed targets.")]
         public SnakeCaseStringEnumConverter()
         {
             NamingStrategy = new SnakeCaseNamingStrategy();

osu.Game/IO/Serialization/Converters/TypedListConverter.cs

@@ -63,11 +63,15 @@ public override IReadOnlyList<T> ReadJson(JsonReader reader, Type objectType, IR
                     throw new JsonException("Expected $type token.");
 
                 // Prevent instantiation of types that do not inherit the type targetted by this converter
+#pragma warning disable IL2057
                 Type type = Type.GetType(lookupTable[(int)tok["$type"]]).AsNonNull();
+#pragma warning restore IL2057
                 if (!type.IsAssignableTo(typeof(T)))
                     continue;
 
+#pragma warning disable IL2072
                 var instance = (T)Activator.CreateInstance(type)!;
+#pragma warning restore IL2072
                 serializer.Populate(itemReader, instance);
 
                 list.Add(instance);