Merge pull request #155 from winnerspiros/fix/android-build-aot-trimming-12206102043476969963

Fix Android AOT build and .NET 10 trimming warnings

Author: winnerspiros

osu.Android.props

@@ -42,4 +42,17 @@
          Since Realm objects are not declared directly in Android projects, simply disable Fody. -->
     <DisableFody>true</DisableFody>
   </PropertyGroup>
+
+  <!-- WORKAROUND: Fix NativeAOT ILC failure on .NET 10 Android (early 2026 regression).
+       The SDK incorrectly stamps AssetType="runtime" on non-DLL files (pdb, so, dbg)
+       in the runtime pack, causing the AOT compiler to fail with BadImageFormatException.
+       This target fixes the metadata before the SDK uses it.
+       See: https://github.com/dotnet/runtime/pull/126214 -->
+  <Target Name="FixRuntimePackAssetTypes" AfterTargets="_AddRuntimeLibsToPublishAssets" BeforeTargets="ComputeManagedAssembliesToCompileToNative">
+    <ItemGroup>
+      <RuntimePackAsset Condition="'%(Extension)' != '.dll'">
+        <AssetType>native</AssetType>
+      </RuntimePackAsset>
+    </ItemGroup>
+  </Target>
 </Project>

osu.Game/Configuration/SettingSourceAttribute.cs

@@ -1,5 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
+using System.Diagnostics.CodeAnalysis;
 
 using System;
 using System.Collections.Concurrent;
@@ -42,6 +43,7 @@ public class SettingSourceAttribute : Attribute, IComparable<SettingSourceAttrib
         /// <remarks>
         /// Must be a type deriving <see cref="SettingsItem{T}"/> with a public parameterless constructor.
         /// </remarks>
+        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor | DynamicallyAccessedMemberTypes.PublicProperties)]
         public Type? SettingControlType { get; set; }
 
         public SettingSourceAttribute(Type declaringType, string label, string? description = null)
@@ -109,6 +111,9 @@ public int CompareTo(SettingSourceAttribute? other)
 
     public static partial class SettingSourceExtensions
     {
+        [UnconditionalSuppressMessage("Trimming", "IL2006", Justification = "The ModSettingsEnumDropdown is correctly generated for the bindable type.")]
+        [UnconditionalSuppressMessage("Trimming", "IL2055", Justification = "The ModSettingsEnumDropdown is correctly generated for the bindable type.")]
+        [UnconditionalSuppressMessage("Trimming", "IL2067", Justification = "The ModSettingsEnumDropdown is correctly generated for the bindable type.")]
         public static IEnumerable<Drawable> CreateSettingsControls(this object obj)
         {
             foreach (var (attr, property) in obj.GetOrderedSettingsSourceProperties())
@@ -260,7 +265,7 @@ public static object GetUnderlyingSettingValue(this object setting)
             return properties;
         }
 
-        private static IEnumerable<(SettingSourceAttribute, PropertyInfo)> getSettingsSourceProperties(Type type)
+        private static IEnumerable<(SettingSourceAttribute, PropertyInfo)> getSettingsSourceProperties([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] Type type)
         {
             foreach (var property in type.GetProperties(BindingFlags.GetProperty | BindingFlags.Public | BindingFlags.Instance))
             {

osu.Game/Database/BackgroundDataStoreProcessor.cs

@@ -1,5 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
+using System.Diagnostics.CodeAnalysis;
 
 using System;
 using System.Collections.Generic;
@@ -340,6 +341,7 @@ private void processBeatmapsWithMissingObjectCounts()
             completeNotification(notification, processedCount, beatmapIds.Count, failedCount);
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "The ScoreInfo.MaximumStatistics is already part of the trimming-safe path in Realm/Json serialization.")]
         private void processScoresWithMissingStatistics()
         {
             HashSet<Guid> scoreIds = new HashSet<Guid>();

osu.Game/IO/Serialization/SnakeCaseKeyContractResolver.cs

@@ -1,11 +1,13 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
+using System.Diagnostics.CodeAnalysis;
 
 using Newtonsoft.Json.Serialization;
 using osu.Game.Extensions;
 
 namespace osu.Game.IO.Serialization
 {
+    [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "The contract resolver is correctly part of the reflection path for Newtonsoft.Json.")]
     public class SnakeCaseKeyContractResolver : DefaultContractResolver
     {
         protected override string ResolvePropertyName(string propertyName)

osu.Game/Input/Bindings/DatabasedKeyBindingContainer.cs

@@ -1,5 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
+using System.Diagnostics.CodeAnalysis;
 
 #nullable disable
 
@@ -49,6 +50,7 @@ public DatabasedKeyBindingContainer(RulesetInfo ruleset = null, int? variant = n
                 throw new InvalidOperationException($"{nameof(variant)} can not be null when a non-null {nameof(ruleset)} is provided.");
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "Realm objects are safe for AsQueryable.")]
         protected override void LoadComplete()
         {
             realmSubscription = realm.RegisterForNotifications(queryRealmKeyBindings, (sender, _) =>