aa

[winnerspiros]

---

Summary by Gitar

• UI adjustment:
  • Modified RankedPlayCard to consistently display card back during content loading state
• Reference:
  • Related to PR Adjust RankedPlayCard to always show card back (when loading content) ppy/osu#37129

_{This will update automatically on new commits.}

Summary by CodeRabbit

• Improvements
  • Streamlined installation migration workflow when detecting existing installs
  • Updated ranked play card display and loading behavior
  • Refined UI behavior for multiplayer readiness controls

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 263a8c66-cda5-48ed-acb5-dc00a85b17a4

📥 Commits

Reviewing files that changed from the base of the PR and between 4835806 and ee2f7a7.

📒 Files selected for processing (7)

• osu.Game.Tests/Visual/RankedPlay/TestSceneDiscardScreen.cs
• osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
• osu.Game.Tests/Visual/RankedPlay/TestScenePickScreen.cs
• osu.Game/Localisation/MaintenanceSettingsStrings.cs
• osu.Game/Overlays/Settings/Sections/Maintenance/MigrationSelectScreen.cs
• osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs
• osu.Game/Screens/OnlinePlay/Multiplayer/Match/MultiplayerReadyButton.cs

---

📝 Walkthrough

Walkthrough

Test scenes for ranked play are updated to use RankedPlayTestScene base class and now configure beatmap request handlers with programmatic card reveals. RankedPlayCard component is refactored to simplify flip-state logic. Migration confirmation flow consolidates dialogs. Localization strings and ready button tooltip override are adjusted.

Changes

Cohort / File(s)	Summary
RankedPlay Test Scene Updates osu.Game.Tests/Visual/RankedPlay/TestSceneDiscardScreen.cs, osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs, osu.Game.Tests/Visual/RankedPlay/TestScenePickScreen.cs	Base class changed to RankedPlayTestScene. Each test now instantiates BeatmapRequestHandler, assigns it to DummyAPIAccess.HandleRequest, adds a wait step, and reveals 5 cards by binding beatmap IDs from request handler data.
RankedPlayCard Refactoring osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs	Simplified state management by removing flip parameter from public/private methods. Back side now always initialized; content starts as Empty(). Replaced loadCardContent() with loadCardContentAsync() and refactored SetContent() signature to accept nullable drawable without flip flag.
Maintenance & Migration Updates osu.Game/Localisation/MaintenanceSettingsStrings.cs, osu.Game/Overlays/Settings/Sections/Maintenance/MigrationSelectScreen.cs	Removed RestartAndReOpenRequiredForCompletion string; merged restart message into TargetDirectoryAlreadyInstalledOsu. Migration dialog consolidated to single confirmation layer with direct RestartAppWhenExited() call on accept.
Ready Button Cleanup osu.Game/Screens/OnlinePlay/Multiplayer/Match/MultiplayerReadyButton.cs	Removed TooltipText override, eliminating conditional "Cancel countdown" text logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 Cards flip less, but show much more,
Tests now unified at the core,
Migrations seamless, dialogs pare,
Tooltips vanish—cleaner air! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}