Skip to content

Fix Oboe Android build error: 'common/Process.h' not found - #124

Merged
winnerspiros merged 2 commits into
masterfrom
fix-oboe-build-error-process-h-not-found-5275952016772964733
Mar 30, 2026
Merged

Fix Oboe Android build error: 'common/Process.h' not found#124
winnerspiros merged 2 commits into
masterfrom
fix-oboe-build-error-process-h-not-found-5275952016772964733

Conversation

@google-labs-jules

Copy link
Copy Markdown

I have fixed the build failure in the Android Oboe bridge caused by the removal of the internal common/Process.h header in the Oboe main branch.

Key changes:

  1. Removed internal Oboe dependency: The code no longer relies on Oboe's private Process.h.
  2. Manual CPU Affinity: Implemented thread pinning using standard Linux sched_setaffinity to ensure the audio callback remains high-performance and low-latency.
  3. Build Configuration Clean-up: Updated CMakeLists.txt to remove unnecessary private include paths for Oboe.
  4. Documentation: Created AGENTS.md to record the rationale for these optimizations and prevent regressions.

The build should now proceed past the native compilation step.


PR created automatically by Jules for task 5275952016772964733 started by @winnerspiros

- Removed `#include <common/Process.h>` from `oboe_bridge.cpp` as it has been removed from Oboe's `main` branch.
- Implemented manual CPU affinity pinning using standard Linux/Android `sched_setaffinity` in `oboe_bridge.cpp`.
- Updated `CMakeLists.txt` to remove private Oboe include paths.
- Added `AGENTS.md` to document the Oboe optimization strategy.

This resolves the fatal error: 'common/Process.h' file not found.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Fixed C++ fatal error: 'common/Process.h' not found by removing dependency on internal Oboe headers.
- Implemented manual CPU affinity pinning using standard Linux/Android `sched_setaffinity` in `oboe_bridge.cpp`.
- Updated `CMakeLists.txt` to remove unnecessary Oboe private include paths.
- Fixed C# error CS0227: Unsafe code may only appear if compiling with /unsafe by adding `<AllowUnsafeBlocks>true</AllowUnsafeBlocks>` to `osu.Android.csproj`.
- Added `AGENTS.md` to document Oboe optimizations and rationale.
@winnerspiros
winnerspiros merged commit 522e547 into master Mar 30, 2026
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant