Fix Android native build failures (Oboe & Vulkan) - #126
Conversation
- Fixed 'reportActualWorkDuration' build error in oboe_bridge.cpp by removing manual ADPF reporting (now handled internally by Oboe main). - Resolved 'byte' type errors in vulkan_bridge.cpp by adding a typedef for uint8_t. - Ensured binary compatibility with C# P/Invoke signatures by using the custom 'byte' type for native exports. - Updated AGENTS.md with current ADPF integration guidelines.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes the build failures in the Android native bridge components:
Oboe Bridge ADPF Fix: The Oboe library's
mainbranch recently removed the publicreportActualWorkDurationmethod fromAudioStream. Research into the Oboe source code confirmed that work duration reporting is now handled internally by Oboe wheneversetPerformanceHintEnabled(true)is set. Manual reporting in the bridge was both causing a build error and becoming redundant.Vulkan Bridge Type Fix: Added a
typedef uint8_t byte;to the Vulkan bridge header to resolve compilation errors where the compiler did not recognize 'byte' as a valid type. This maintains perfect binary compatibility with the managed C# side which expects a single-byte return value for these capability probes.Documentation Update: Updated
AGENTS.mdto reflect these architectural changes in the Oboe integration.PR created automatically by Jules for task 9831564879716892517 started by @winnerspiros