Fix Oboe muting and optimize performance for S23 Ultra - #127
Conversation
- Fixed muting issue by implementing robust reflection search for BASS mixer handles in `OboeAudioRedirector.cs`. - Ensured Oboe is always used when enabled by removing the fallback safeguard. - Optimized latency by disabling BASS-internal buffering on the master mixer. - Refined CPU affinity in `oboe_bridge.cpp` to target high-performance cores (3-7) on Snapdragon 8 Gen 2/3 devices. - Kept 2x burst start with LatencyTuner for stability as requested.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a critical muting issue when "Low latency audio (Oboe)" is enabled on Android. The root cause was a fragile reflection-based handle retrieval in
OboeAudioRedirector.csthat failed if framework internal field names changed.The fix implements a multi-strategy search across the inheritance chain for common BASS handle names. Additionally, the PR introduces several performance optimizations specifically for high-end devices like the S23 Ultra:
PR created automatically by Jules for task 12222287418414949344 started by @winnerspiros