Android: Improve Vulkan stability and Oboe diagnostics - #135
Conversation
This PR addresses performance and stability issues with Vulkan and Oboe on high-end Android devices like the S23 Ultra. Key Improvements: - Fixed Vulkan mailbox detection in the native probe to ensure smoother frame pacing and reduced flickering. - Updated Vulkan 'IsRecommended' logic to include Graphics Pipeline Library and Shader Object extensions, ensuring optimal driver paths. - Enhanced Oboe auto-offset calibration to apply suggestions more proactively, regardless of existing manual offsets. - Added a diagnostic display in the FPSCounter overlay showing the active renderer and Oboe stream details (API, MMAP mode, and real-time latency). - Cleaned up manual ADPF reporting in favor of Oboe's internal implementation, reducing overhead and aligning with current library standards. - Refined native Oboe stream initialization to favor the lowest-latency MMAP and Exclusive paths.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fixed Vulkan mailbox detection in native probe. - Updated Vulkan recommendation logic for S23 Ultra. - Added Oboe status and active renderer to FPS display. - Improved Oboe auto-offset calibration. - Cleaned up redundant manual ADPF reporting. - Fixed CI build error in FPSCounter.cs by using GameHost for ResolvedRenderer.
- Fixed Vulkan mailbox detection in native probe to improve frame pacing. - Updated Vulkan recommendation logic to require Graphics Pipeline Library and Shader Objects. - Added Oboe status (API, MMAP mode, latency) and active renderer to the FPS display. - Enhanced Oboe auto-offset calibration to always suggest the hardware-detected offset on startup. - Removed redundant manual ADPF duration reporting. - Fixed build errors by using ScheduledDelegate and cleaning up obsolete ADPF variables in OsuGameAndroid.cs.
1 participant
This PR addresses performance and stability issues with Vulkan and Oboe on high-end Android devices like the S23 Ultra.
Key Improvements:
PR created automatically by Jules for task 7832751681472622993 started by @winnerspiros