Fix Vulkan flickering, Oboe visibility, and restore performance optimizations - #136
Conversation
…izations - Fixed Oboe status visibility in FPS counter by updating type check to OsuGameBase. - Updated native Vulkan probe to detect and recommend Vulkan 1.4 for modern Android devices. - Forced Mailbox present mode on Vulkan to eliminate flickering and improve input latency. - Fixed a significant memory leak in OsuGameAndroid where audio mixer event handlers were never unbound. - Corrected delegate storage for audio mixer collection changes to ensure reliable redirection updates. - Restored broken high-performance session management and ADPF integration. - Improved resource cleanup in OboeAudioRedirector to prevent unmanaged handle leaks. - Fixed FPSCounter visual tests by making dependencies optional in the test environment.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| [Resolved] | ||
| protected OsuGame Game { get; private set; } = null!; | ||
| [Resolved(canBeNull: true)] | ||
| protected OsuGameBase? Game { get; private set; } = null!; |
Check warning
Code scanning / InspectCode
Redundant member initializer Warning
| [Resolved] | ||
| private GameHost host { get; set; } = null!; | ||
| [Resolved(canBeNull: true)] | ||
| private GameHost? host { get; set; } = null!; |
Check warning
Code scanning / InspectCode
Redundant member initializer Warning
…izations - Fixed Oboe status visibility in FPS counter by updating type check to OsuGameBase. - Updated native Vulkan probe to detect and recommend Vulkan 1.4 for modern Android devices. - Forced Mailbox present mode on Vulkan to eliminate flickering and improve input latency. - Fixed a significant memory leak in OsuGameAndroid where audio mixer event handlers were never unbound. - Corrected delegate storage for audio mixer collection changes to ensure reliable redirection updates. - Restored broken high-performance session management and ADPF integration. - Improved resource cleanup in OboeAudioRedirector to prevent unmanaged handle leaks. - Fixed FPSCounter visual tests by making dependencies optional in the test environment.
2 participants
This PR addresses multiple issues reported on high-end Android devices (specifically S23 Ultra):
Oboe Audio Visibility & Reliability:
OsuGame(Android usesOsuGameAndroid).OsuGameAndroid.cswhere theactiveMixerscollection-changed handler was not being stored, preventing it from being correctly unbound on disposal (causing memory leaks) and potentially missing mixer updates.Vulkan Optimizations:
VulkanProbeto detect and recommend Vulkan 1.4. This allows the game to leverage modern driver features on Snapdragon 8 Gen 2/3 devices.Mailboxpresent mode when running on Vulkan on Android. This eliminates the "flickering/glitching" reported during animations by allowing the game to render at maximum speed while perfectly syncing the latest finished frame to the display.Performance & Memory Management:
LoadComplete.AndroidHighPerformanceSessionManagercorrectly into the performance toggle lifecycle.Reliability:
TestSceneFPSCounterby making its dependencies (Gameandhost) optional, allowing the component to load in restricted test environments.PR created automatically by Jules for task 15867747922127386612 started by @winnerspiros