Android: Improve Oboe and Vulkan robustness on S23 Ultra - #138
Conversation
- Enhanced native library loading in OboeAudioBridge and VulkanProbe with fallbacks for Samsung device security policies. - Implemented resilient Oboe stream initialization in oboe_bridge.cpp with SharingMode::Shared fallback. - Added targeted Vulkan workaround for Adreno 740 (S23 Ultra) to disable present_id/wait extensions causing flickering. - Fixed Oboe status visibility in FPS counter by ensuring properties are correctly overridden in OsuGameAndroid. - Added comprehensive native bridge logging to diagnose startup initialization failures.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Enhanced native library loading in OboeAudioBridge and VulkanProbe with fallbacks for Samsung device security policies. - Implemented resilient Oboe stream initialization in oboe_bridge.cpp with SharingMode::Shared fallback. - Added targeted Vulkan workaround for Adreno 740 (S23 Ultra) to disable present_id/wait extensions causing flickering. - Fixed Oboe status visibility in FPS counter by ensuring properties are correctly overridden in OsuGameAndroid. - Added comprehensive native bridge logging to diagnose startup initialization failures. - Fixed NullReferenceException in PlaylistItem constructor and improved robustness in MultiplayerClient. - Simplified null checks in SongPreview to satisfy code style rules.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// </remarks> | ||
| public PlaylistItem(MultiplayerPlaylistItem item) | ||
| : this(new APIBeatmap { OnlineID = item.BeatmapID, StarRating = item.StarRating, Checksum = item.BeatmapChecksum }) | ||
| : this(item == null ? new APIBeatmap() : new APIBeatmap { OnlineID = item.BeatmapID, StarRating = item.StarRating, Checksum = item.BeatmapChecksum }) |
2 participants
This PR addresses issues where Oboe audio was not engaging and Vulkan was flickering on the S23 Ultra.
Key changes:
osu_nativeis loaded even on devices with restrictive search path policies.PR created automatically by Jules for task 7037210485410256682 started by @winnerspiros