Resolve Vulkan performance gap and flickering on Adreno 7xx GPUs - #140
Conversation
This change addresses the "half FPS" (60 vs 120) and flickering issues on modern Android devices like the S23 Ultra (Snapdragon 8 Gen 2/3). - Native Bridge: Enhanced Adreno 7xx detection to blacklist VK_KHR_present_id/wait (flicker fix) and VK_EXT_graphics_pipeline_library (performance fix). - Managed Injection: Implemented early environment variable injection in OsuGameAndroid.SetHost to force VULKAN_PRESENT_MODE=MAILBOX and VULKAN_DISABLE_EXTENSIONS based on hardware probe findings. - Diagnostics: Added 'VulkanStatus' to the expanded FPS counter HUD, displaying active present modes (MAILBOX/FIFO) and enabled overrides ([NoID], [NoWait], [NoGPL]). - Surface Support: Added probing for VK_EXT_surface_maintenance1 for improved frame pacing on Android 13+.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change addresses the "half FPS" (60 vs 120) and flickering issues on modern Android devices like the S23 Ultra (Snapdragon 8 Gen 2/3). - Native Bridge: Enhanced Adreno 7xx detection to blacklist VK_KHR_present_id/wait (flicker fix) and VK_EXT_graphics_pipeline_library (performance fix). - Managed Injection: Implemented early environment variable injection in OsuGameAndroid.SetHost (using fully qualified System.Environment) to force VULKAN_PRESENT_MODE=MAILBOX and VULKAN_DISABLE_EXTENSIONS based on hardware probe findings. - Diagnostics: Added 'VulkanStatus' to the expanded FPS counter HUD, displaying active present modes (MAILBOX/FIFO) and enabled overrides ([NoID], [NoWait], [NoGPL]). - Surface Support: Added probing for VK_EXT_surface_maintenance1 for improved frame pacing on Android 13+.
Addressing the Vulkan performance gap (half FPS) and flickering on modern Adreno 7xx GPUs (S23 Ultra).
Key Implementation Details:
PR created automatically by Jules for task 13806510936200067795 started by @winnerspiros