Revert gameplay regressions and optimize Android threading - #143
Conversation
- Reverted DrawableHitObject, SnakingSliderBody, DrawableSlider, DrawableHitCircle, and DrawableOsuJudgement to a known good state to fix missing approach circles and incorrect slider rendering. - Optimized multithreading by pinning the Input thread to high-performance cores (mask 0xF8) alongside Update and Render threads. - Improved HUD performance by implementing lazy caching for Vulkan and Oboe status strings in AndroidNativeBridgeManager, eliminating per-update allocations. - Applied AggressiveInlining to critical bridge properties (IsActive, IsAAudio, IsMMap) to reduce overhead in high-frequency status checks. - Restored necessary ADPF and native bridge declarations required for Android performance management.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Reverted DrawableHitObject, SnakingSliderBody, DrawableSlider, DrawableHitCircle, and DrawableOsuJudgement to commit de344f2 to fix missing approach circles and incorrect slider rendering. - Optimized multithreading by pinning the Input thread to high-performance cores (mask 0xF8) alongside Update and Render threads. - Improved HUD performance by implementing lazy caching for Vulkan and Oboe status strings in AndroidNativeBridgeManager, eliminating per-update allocations. - Applied AggressiveInlining to critical bridge property getters (IsActive, IsAAudio, IsMMap) to reduce overhead in high-frequency status checks. - Fixed compilation errors by moving MethodImpl attributes to property accessors. - Restored necessary ADPF and native bridge declarations required for Android performance management.
1 participant
This PR reverts recent "optimizations" that caused visual regressions on Android (missing approach circles, broken sliders) and replaces them with safer, generic performance improvements.
Key changes:
PR created automatically by Jules for task 10080506137969536493 started by @winnerspiros