Fix Android build trimming and AOT errors - #156
Conversation
- Added [UnconditionalSuppressMessage] to several classes in osu.Game to suppress trimming warnings from Newtonsoft.Json and IBindable reflection. - Annotated SettingSourceAttribute constructor with [DynamicallyAccessedMembers] to preserve type members for settings UI generation. - Created Linker.xml in osu.Android to explicitly preserve PriorityQueue'2 in System.Private.CoreLib, resolving a MessagePack.dll AOT failure.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change addresses several build errors and warnings encountered during the Android APK build in .NET 10.
Specifically, it resolves trimming warnings in
BindableValueAccessor,TypedListConverter,SnakeCaseStringEnumConverter, andJsonSerializableExtensionswhere reflection is intentionally used for core framework logic.It also fixes a critical AOT failure in
MessagePack.dllby ensuring thatPriorityQueue'2is not stripped by the linker, as reported in the build logs.Additionally,
SettingSourceAttributeis updated with necessary annotations to support aggressive trimming while maintaining the functionality of the settings UI.PR created automatically by Jules for task 3008086234740976622 started by @winnerspiros