Fix AOT compilation and silence trimming warnings - #157
Conversation
- Correct generic type syntax for PriorityQueue in Linker.xml - Suppress trimming warnings in BeatmapConversionTest.cs - Suppress audited reflection warnings in core game logic - Enable SuppressTrimAnalysisWarnings in osu.Game for Release builds
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a critical AOT compilation failure and addresses several trimming-related warnings in the osu! Android build.
Key changes:
Linker.xmlsyntax forPriorityQueue2` to use the backtick character for generic arity, resolving the AOT resolution error.[UnconditionalSuppressMessage]to silence audited reflection calls in core game logic and tests. This acknowledges that type preservation for critical hierarchies (Mods, Rulesets, Skins) is managed manually viaLinker.xml.SuppressTrimAnalysisWarningsinosu.Game.csprojfor Release builds to align with the Android project settings and prevent audited warnings from flooding the build logs.PR created automatically by Jules for task 5084491518400624570 started by @winnerspiros