Fix Android build and optimize trimming - #158
Conversation
- Resolved PriorityQueue resolution error in Linker.xml by using System.Runtime. - Added explicit preserves for MessagePack and AutoMapper in Linker.xml to prevent AOT compiler crashes during aggressive trimming. - Enabled more aggressive trimming in osu.Android.props by setting TrimMode to full and AndroidLinkMode to Full. - Simplified the GitHub Actions release workflow by centralizing build properties in the project configuration. - Ensured consistent trimming behavior across build environments.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes a build error where the linker could not resolve System.Collections.Generic.PriorityQueue'2 by updating the assembly fullname in Linker.xml to System.Runtime. It also adds explicit preserves for MessagePack and AutoMapper to prevent AOT compiler crashes when using aggressive trimming. Trimming has been optimized by setting TrimMode to full and AndroidLinkMode to Full in osu.Android.props, and the release workflow has been simplified to use these centralized settings.
PR created automatically by Jules for task 13159275510640310113 started by @winnerspiros