Fix Android build failures caused by trimming and unresolvable linker types - #160
Conversation
… types - Removed obsolete AutoMapper.Configuration.ProxyBase from Linker.xml (confirmed absent/removed) - Expanded [UnconditionalSuppressMessage] attributes in OsuGameAndroid.cs and OboeAudioRedirector.cs - Added IL2067, IL2070, and IL2072 to suppressions for dynamic reflection on AudioManager and AudioMixer types - Verified that these suppressions cover all reported 'DynamicallyAccessedMemberTypes' mismatches in the Android project.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses build errors encountered when building the Android APK in Release mode with aggressive trimming enabled.
Key changes:
[UnconditionalSuppressMessage]attributes inOsuGameAndroid.csandOboeAudioRedirector.csto cover IL2067, IL2070, and IL2072. These warnings were triggered by reflection calls on types preserved inLinker.xml. By adding these suppressions, we satisfy the compiler while maintaining runtime safety.AutoMapper.Configuration.ProxyBaseinLinker.xml. This type is obsolete in newer versions of AutoMapper and its presence caused resolution failures during the linking phase.osu.Gameproject still builds correctly and confirmed the application of all suppressions.PR created automatically by Jules for task 12996628315585577934 started by @winnerspiros