Android: Fix IL Linker Crash and Optimize Trimming - #165
Conversation
- Added SuppressTrimAnalysisWarnings to osu.Android.props to bypass IL1012 linker crash - Added UnconditionalSuppressMessage to reflection-heavy methods in OsuGameAndroid.cs - Preserved OboeAudioRedirector in Linker.xml to prevent stripping - Standardized reflection suppressions across the Android project
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added SuppressTrimAnalysisWarnings to osu.Android.props to bypass IL1012 linker crash - Added UnconditionalSuppressMessage to reflection-heavy methods in OsuGameAndroid.cs - Preserved OboeAudioRedirector in Linker.xml to prevent stripping - Standardized reflection suppressions across the Android project
…lity - Resolved IL1012 linker crash by suppressing trim analysis warnings in props. - Corrected Linker.xml syntax (replaced wildcards with namespace tags). - Added explicit assembly preservation for Realm, AutoMapper, and Newtonsoft.Json. - Suppressed reflection warnings in OsuGameAndroid.cs for audio mixer binding. - Removed redundant BCL assembly preservations.
1 participant
This pull request addresses the 'Fatal error in IL Linker' (IL1012) encountered during Android builds by bypassing the trimmer's warning reporting phase for reflection-heavy code. It also improves trimming safety by explicitly preserving critical types in Linker.xml and adding necessary suppressions to the source code.
PR created automatically by Jules for task 13683698734519452788 started by @winnerspiros