Fix JNI activation crash and trimming regressions on Android - #167
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Removed the explicit JNI constructor from OsuGameActivity as AndroidGameActivity does not expose one (fixing CI error CS1729). - Refactored initialization logic into a private initialise() method called by the default constructor. - Proactively preserved osu.Framework.Android and osu.Framework.Platform.Android namespaces in Linker.xml to ensure JNI activation glue survives trimming. - Wildcard-preserved all types in the osu.Android assembly in Linker.xml. - Preserved Veldrid.Vk, SPIRV, and osu.Game.Resources to prevent rendering and asset regressions. - Silenced IL2026/IL2067/IL2070/IL2072/IL2075/IL2080/IL2106 trimming warnings in OsuGameActivity, OsuGameAndroid, and OboeAudioRedirector.
1 participant
This PR addresses a fatal System.NotSupportedException during JNI activation of OsuGameActivity on trimmed Android builds. It also proactively resolves several trimming-related regressions and build warnings.
Key changes:
PR created automatically by Jules for task 12196497986789418403 started by @winnerspiros