Fix Android JNI Activation Crash - #169
Conversation
…ng the Activity constructor.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The app was crashing with System.NotSupportedException during JNI activation of OsuGameActivity. Key changes: 1. **Relaxed Trimming:** Set TrimMode to 'partial' and AndroidLinkMode to 'SdkOnly' in osu.Android.props. This prevents the linker from stripping critical JNI metadata in the app's own assemblies, which was the root cause of the activation failure. 2. **Verified Activity Compatibility:** Re-verified that OsuGameActivity is source-compatible with ppy.osu.Framework.Android's base activity class. 3. **Build Stabilization:** Confirmed that the Android project builds and that core game tests pass, ensuring no regressions in the shared codebase.
1 participant
Corrected the OsuGameActivity JNI constructor to pass handles to base and relaxed trimming to 'partial' for better stability. This resolves the System.NotSupportedException during JNI activation.
PR created automatically by Jules for task 12815997710024876077 started by @winnerspiros