Fix Linker warnings and AOT crash for Android - #171
Conversation
This resolves build warnings where the linker could not resolve the 'Veldrid' and 'Veldrid.SPIRV' assemblies, nor the 'osu.Framework.Platform.Android' namespace. In .NET 10 builds, these resolution failures can lead to Mono AOT runtime crashes (assertion 'plt_entry not met') due to inconsistencies between linked assemblies and AOT-compiled code. The 'Veldrid' references are redundant as the project uses 'ppy.Veldrid.SPIRV', and the 'osu.Framework.Platform.Android' namespace has been consolidated into 'osu.Framework.Android'.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Removed unresolvable 'Veldrid' and 'Veldrid.SPIRV' assembly entries from
osu.Android/Linker.xml.Removed the obsolete 'osu.Framework.Platform.Android' namespace from the same file.
These changes resolve build-time warnings and potential Mono AOT runtime crashes on Android.
PR created automatically by Jules for task 7885475822605352576 started by @winnerspiros