fix(android): resolve AOT crash by removing obsolete Veldrid entry - #172
Conversation
The `plt_entry not met` assertion in the Mono AOT runtime was caused by the linker attempting to resolve `ppy.Veldrid.SPIRV`, which is no longer part of the project's dependency graph. This removes the assembly from `Linker.xml` and cleans up related comments in `osu.Android.props` to resolve the crash on .NET 10 Android builds.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reverts the codebase to the state of commit 50b2298 from PR 'fix/android-native-build-byte-type-error-10772562851119172684'. This effectively undoes the subsequent merge of PR #172, which was identified as the cause of the regressions in the current build. The 'byte' type fix for native headers is preserved as part of the target commit.
1 participant
Removes the obsolete
ppy.Veldrid.SPIRVassembly fromLinker.xmland cleans up the corresponding TODO inosu.Android.props. This assembly was causing a fatalplt_entry not metassertion in the Mono AOT runtime during application startup on Android. Verified that the core library build succeeds and that reflection-heavy code paths remain protected by existing trimmer suppressions.PR created automatically by Jules for task 5598476388993846542 started by @winnerspiros