Skip to content

Fix native build: ANDROID_PLATFORM android-36 exceeds NDK r29 max (35) - #201

Merged
winnerspiros merged 1 commit into
masterfrom
copilot/fix-last-build-failure
Apr 18, 2026
Merged

Fix native build: ANDROID_PLATFORM android-36 exceeds NDK r29 max (35)#201
winnerspiros merged 1 commit into
masterfrom
copilot/fix-last-build-failure

Conversation

Copilot AI commented Apr 18, 2026

Copy link
Copy Markdown

CMake native build step fails because ANDROID_PLATFORM=android-36 exceeds NDK r29's maximum supported API level of 35.

  • Changed ANDROID_PLATFORM from android-36 to android-33 in release.yml, matching minSdkVersion in AndroidManifest.xml. Native code doesn't use any API 34+ NDK symbols, so the minimum platform is sufficient. targetSdkVersion=36 is a manifest/Java concept and doesn't constrain the native build platform.

… is 35)

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/4734fa6f-319f-407b-b578-11f4a6c62b9d

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
@gitar-bot

gitar-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@winnerspiros
winnerspiros marked this pull request as ready for review April 18, 2026 23:33
Copilot AI review requested due to automatic review settings April 18, 2026 23:33
@winnerspiros
winnerspiros merged commit e8f6000 into master Apr 18, 2026
2 of 16 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Android release workflow to use an NDK-supported native build API level, fixing CMake failures caused by ANDROID_PLATFORM=android-36 exceeding NDK r29’s max supported API level.

Changes:

  • Set CMake ANDROID_PLATFORM from android-36 to android-33 in the GitHub Actions release workflow.
  • Align native build platform with the app’s minSdkVersion (33), independent of targetSdkVersion (36).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants