Marshal SetSustainedPerformanceMode onto the Android UI thread

[Copilot]

OsuGameAndroid.LoadComplete invoked Window.SetSustainedPerformanceMode(true) from the load thread. ViewRootImpl.checkThread() threw CalledFromWrongThreadException after window private flags had already been partially mutated, leaving the active VkSurfaceKHR pointing at freed driver state — the next frame crashed inside qglinternal::vkCmdBeginRendering (vulkan.adreno.so + 0x4, fault_addr=0x28), followed by an input-dispatch ANR.

Changes

• osu.Android/OsuGameAndroid.cs — wrap the SetSustainedPerformanceMode call in gameActivity.RunOnUiThread(...), matching the pattern already used by every other Window/Window.Attributes mutator in this file (applyPerformanceOptimizations, applyDeXImmersiveMode, applyDisplayMode, RequestUnbufferedDispatch). Outer try/catch guards the dispatch itself; inner try/catch preserves the existing best-effort semantics.

gameActivity.RunOnUiThread(() =>
{
    try { gameActivity.Window?.SetSustainedPerformanceMode(true); }
    catch (Exception e) { Debug.WriteLine($"[osu!] Failed to enable sustained performance mode: {e.Message}"); }
});

Notes

• No osu-framework changes required; the offending call lives entirely in this repo.
• The pre-existing Vulkan surface-init guard in the framework submodule is unrelated and remains in place for cold-start surface readiness.

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[Copilot]

Pull request overview

Fixes an Android threading violation where Window.SetSustainedPerformanceMode(true) was being invoked off the UI thread during OsuGameAndroid.LoadComplete(), leading to CalledFromWrongThreadException and (on some devices) destabilising the active Vulkan surface.

Changes:

• Dispatch SetSustainedPerformanceMode(true) via gameActivity.RunOnUiThread(...).
• Add structured try/catch handling to preserve best-effort behaviour while avoiding unhandled exceptions.
• Document the underlying Android ViewRootImpl.checkThread() constraint and the observed Vulkan crash chain.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.