Update osu-framework to 2026.502.1; add disable-pen-click toggle; fix DeX double cursor - #289
Merged
Merged
Conversation
… cursor on SurfaceView Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/9e4704cb-dc9c-48d9-a063-a068bd1cb558 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/9e4704cb-dc9c-48d9-a063-a068bd1cb558 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
May 2, 2026 15:06
View session
winnerspiros
marked this pull request as ready for review
May 2, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent Android/stylus fixes bundled together.
Package update
ppy.osu.Framework/.Android/.iOS:2026.501.2→2026.502.1(osu-framework pack run Apply CheckLowDiffOverlaps to lowest difficulty Normals #19, commit650ed84d)ppy.Veldrid.SPIRVcomment to reference the new versionDisable pen click (S Pen)
New
AndroidStylusDisableClicksetting (defaultfalse). When enabled, the stylus tip never synthesises a left-click — useful for cursor-only pen use with a separate keyboard/gamepad input method.OsuSetting.AndroidStylusDisableClickwired throughOsuGameAndroid→AndroidStylusHandler.DisableClick(volatile, hot-path safe)isLeftDown = truepaths guarded by!DisableClick;Up/Cancel/ButtonReleasestill clears state normallyAndroidStylusSettingsabove the existing "Treat S Pen as touch" checkboxDeX double cursor
PointerIcon.Nullwas only set onDecorView. Android resolves pointer icons from the innermost hit-tested view, so theSurfaceViewwas still showing the system arrow in DeX mode. Fix setsPointerIcon.Nullon theSurfaceViewas well, inside the existingDecorView.Postlambda where it's guaranteed to be attached.