bump osu-framework to 2026.504.3 - #301
Merged
Merged
Conversation
…Launcher, audio offset UX Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/62d6e310-b56e-4f11-9f94-fdff8c3c665d Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…1x users Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/09cd040f-c004-401d-925b-43622580ffdb Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…rPass TBR clear) Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/0bbf55a6-e45a-4dd0-af20-c261afb97c7c Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
May 4, 2026 17:35
View session
winnerspiros
marked this pull request as ready for review
May 4, 2026 17:35
|
|
There was a problem hiding this comment.
Pull request overview
Updates the repository to consume winnerspiros/osu-framework 2026.504.3, while also introducing several Android-specific runtime and UX adjustments related to audio latency guidance, FrameSync migration, and Samsung Game Launcher discovery.
Changes:
- Bump
ppy.osu.Frameworkpackage references (Desktop, Android, iOS) from2026.504.2to2026.504.3. - Add an Android FrameSync “v3” migration flag and logic to move users from
Limit1xback toActualUnlimitedunder specific conditions. - Add Android UX/behaviour updates: expanded “Resync hardware audio offset” guidance and best-effort Samsung Game Launcher self-registration + manifest category.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| osu.iOS.props | Bumps ppy.osu.Framework.iOS to 2026.504.3. |
| osu.Android.props | Bumps ppy.osu.Framework.Android to 2026.504.3. |
| osu.Game/osu.Game.csproj | Bumps ppy.osu.Framework to 2026.504.3 and updates the accompanying comment. |
| osu.Game/Overlays/Settings/Sections/Audio/AndroidAudioSettings.cs | Expands user-facing tooltip/help text for hardware audio offset resync (Bluetooth caveats). |
| osu.Game/Configuration/OsuConfigManager.cs | Adds AndroidStartupFrameSyncV3MigrationApplied default + enum entry. |
| osu.Android/OsuGameAndroid.cs | Implements FrameSync v3 migration (Limit1x → ActualUnlimited) gated by a new local-config flag. |
| osu.Android/OsuGameActivity.cs | Adds Samsung game category intent-filter and broadcasts a best-effort Game Launcher rescan request on launch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+74
| // Note: AudioOffset shifts the ENTIRE gameplay clock — audio track, hit | ||
| // object visual timing, and hit sound effects all move together. This keeps | ||
| // everything internally consistent regardless of the offset value you choose. |
| TooltipText = "Measures the device's AAudio pipeline latency over 2 s and applies the median to the audio offset. " | ||
| + "NOTE: does NOT include Bluetooth transmission delay (~100–300 ms extra). " | ||
| + "For Bluetooth speakers/headphones, resync first, then fine-tune the offset manually until music and hit sounds feel right. " | ||
| + "The offset shifts the entire game clock — audio, hit objects, and effects all move together.", |
Comment on lines
+41
to
+44
| <PackageReference Include="ppy.osu.Framework" Version="2026.504.3" /> | ||
| <!-- | ||
| Explicitly pin `ppy.Veldrid.SPIRV` to the winnerspiros fork build that | ||
| `ppy.osu.Framework 2026.504.2` was compiled against. This version is the only | ||
| `ppy.osu.Framework 2026.504.3` was compiled against. This version is the only |
… framework 2026.504.3 Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/6d9758b5-4a70-46dc-9493-c41ff4d8a561 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
winnerspiros
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ppy.osu.Framework/.Android/.iOSfrom2026.504.2→2026.504.3Build only (Android)CI failure:FrameSync.Limit1xremoved from framework enum in 2026.504.3 — remove dead v3 migration comparison inOsuGameAndroid.cs