Fix "Click to see what's new!" notification no longer appearing (#37875) - #352
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR restores the update-complete notification ("Click to see what's new") that was missing after recent changes. Version comparison logic is restructured: UpdateCompleteNotification becomes public and relocated in UpdateManager, while OsuGame.LoadComplete now performs the version comparison after config migrations and triggers the notification for deployed builds with changed versions. ChangesUpdate notification restoration for deployed builds
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OsuGameppy/osu#37839.I feel like
UpdateManagershould remain a background component, so moving this notification into a new stable execution path is best to me.Summary by CodeRabbit
New Features
Improvements