Skip to content

Fix "Click to see what's new!" notification no longer appearing (#37875) - #352

Merged
winnerspiros merged 1 commit into
winnerspiros:masterfrom
ppy:master
May 23, 2026
Merged

Fix "Click to see what's new!" notification no longer appearing (#37875)#352
winnerspiros merged 1 commit into
winnerspiros:masterfrom
ppy:master

Conversation

@winnerspiros

@winnerspiros winnerspiros commented May 23, 2026

Copy link
Copy Markdown
Owner

I feel like UpdateManager should remain a background component, so moving this notification into a new stable execution path is best to me.

Summary by CodeRabbit

  • New Features

    • Update completion notifications now display on deployed builds when a version change is detected.
  • Improvements

    • Update detection now occurs after configuration migrations for more accurate version comparison.

Review Change Stack

- Regressed with #37839.
- Closes #37870

I feel like `UpdateManager` should remain a background component, so
moving this notification into a new stable execution path is best to me.
Copilot AI review requested due to automatic review settings May 23, 2026 16:19
@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89a88aec-76f8-4935-8b9b-59b43b7a2281

📥 Commits

Reviewing files that changed from the base of the PR and between 3cb83d0 and 9684398.

📒 Files selected for processing (2)
  • osu.Game/OsuGame.cs
  • osu.Game/Updater/UpdateManager.cs

📝 Walkthrough

Walkthrough

This PR restores the update-complete notification ("Click to see what's new") that was missing after recent changes. Version comparison logic is restructured: UpdateCompleteNotification becomes public and relocated in UpdateManager, while OsuGame.LoadComplete now performs the version comparison after config migrations and triggers the notification for deployed builds with changed versions.

Changes

Update notification restoration for deployed builds

Layer / File(s) Summary
UpdateManager notification exposure and scoped posting
osu.Game/Updater/UpdateManager.cs
UpdateCompleteNotification is made public and repositioned in the file. LoadComplete() now scopes the version comparison and notification posting inside the game.IsDeployedBuild conditional, ensuring the notification only posts for deployed builds.
OsuGame version comparison and notification trigger
osu.Game/OsuGame.cs
LoadComplete() now reads the saved config version after migrations, compares it to the current build version, posts UpdateCompleteNotification when the version has changed on a deployed build, and then updates the stored version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A version lost, a notification gone,
Now checks compare from dusk to dawn,
The update bell rings loud and clear,
"What's new, dear friend?" we'll always hear! 🔔

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@winnerspiros
winnerspiros merged commit 53d0ffb into winnerspiros:master May 23, 2026
4 of 9 checks passed
@winnerspiros
winnerspiros removed the request for review from Copilot May 23, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Click to see what's new" disappeared in last tachyon update

2 participants