Skip to content

Exclude Native/build artifacts from osu.Android compilation - #60

Merged
winnerspiros merged 1 commit into
masterfrom
fix-android-native-build-excludes-1431480136510454656
Feb 5, 2026
Merged

Exclude Native/build artifacts from osu.Android compilation#60
winnerspiros merged 1 commit into
masterfrom
fix-android-native-build-excludes-1431480136510454656

Conversation

@winnerspiros

Copy link
Copy Markdown
Owner

Fixes duplicate class errors during Android Release build by excluding the native build artifacts directory from the project.


PR created automatically by Jules for task 1431480136510454656 started by @winnerspiros

The `osu.Android/Native/build` directory contains intermediate build artifacts from the native build process, including downloaded source code for dependencies like Oboe.
The Android .NET SDK automatically includes `**/*.java` files as `AndroidJavaSource`, causing `javac` to attempt to compile the test files found in `Native/build/.../oboe-src/apps/OboeTester`.
This results in "duplicate class" errors during the build.

This commit adds `Native/build/**` to `DefaultItemExcludes` in `osu.Android.csproj` to prevent these files from being picked up by the build system.

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@winnerspiros
winnerspiros merged commit 22ff741 into master Feb 5, 2026
30 of 31 checks passed
Copilot AI added a commit that referenced this pull request May 27, 2026
- Merge upstream 'Update framework' commit (ppy/master b55ca84)
- Bump ppy.osu.Framework / Android / iOS from 2026.526.1 → 2026.527.1
  (winnerspiros pack run #60, commit f47338d3, 2026-05-27)
  Includes: veldrid deferred AllowTearing swapchain + Adreno sync2 logging,
  InspectCode RectangleF/RectangleI.Empty fix, TrackBass sync reinit on device update
- ppy.Veldrid.SPIRV unchanged (1.0.15-gb268bf39ea)
- Prioritised fork versions over ppy's 2026.527.0 official build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant