Fix redundant transforms in OsuDropdown.UpdateSize - #70
Conversation
Using `Precision.AlmostEquals` for size comparison prevents spamming transforms when the size fluctuates slightly due to floating point inaccuracies. This addresses a TODO comment in the code. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…creen test Using `Precision.AlmostEquals` for size comparison prevents spamming transforms when the size fluctuates slightly due to floating point inaccuracies. This addresses a TODO comment in the code. Also fixes a flaky test `TestSceneResultsScreen.TestShowStatisticsAndClickOtherPanel` by ensuring panels are fully loaded before interaction. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 participant
Replaces strict equality check in
OsuDropdown.UpdateSizewithPrecision.AlmostEqualsto handle floating point jitter and prevent redundantResizeTocalls. Removes the associated TODO comment.PR created automatically by Jules for task 11648886054742302171 started by @winnerspiros