Fix LegacyStoryboardDecoder variable substitution with suffixes - #75
Conversation
- Implemented longest-prefix matching for variable expansion to support suffixes (e.g., $var56 -> value56). - Fixed CS8600 warning (nullable reference types). - Fixed CA1846 warning (prefer AsSpan). - Verified with LegacyStoryboardDecoderTest. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fixed formatting (IDE0055) and implicit type warning (IDE0008) in `LegacyStoryboardDecoder.cs`. - Updated `global.json` to use `rollForward: latestFeature` to ensure .NET 8 SDK is used instead of rolling forward to incompatible .NET 10 previews on CI. - Verified fixes with `dotnet format` and unit tests. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Updated `osu.Android/Native/VulkanRenderer.cs` to accept `IntPtr` for `Initialize`, matching the `Window.Handle` passed from `OsuGameAndroid.cs` and resolving the `cannot convert from 'nint' to 'Android.Views.Surface'` compilation error. - Fixed code style (blank lines) in `LegacyStoryboardDecoder.cs`. - Retained the CI fix for SDK version (rollForward: latestFeature). Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
|
errors again, fix |
I have analyzed the recent CI failures (Code Style and Android Build) and pushed a fix in the latest commit (
Please let me know if any issues persist. |
- Updated `osu.Android/Native/VulkanRenderer.cs` to accept `IntPtr` for `Initialize`, matching the `Window.Handle` passed from `OsuGameAndroid.cs` and resolving the `cannot convert from 'nint' to 'Android.Views.Surface'` compilation error. - Fixed code style (blank lines) in `LegacyStoryboardDecoder.cs`. - Retained the CI fix for SDK version (rollForward: latestFeature). Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Inserted missing blank lines in `LegacyStoryboardDecoder.cs` (lines 393, 428) to comply with CodeFileSanity checks. - Updated `VulkanRenderer.Initialize` to accept `IntPtr` to match the window handle passed from `OsuGameAndroid.cs`, resolving the CS1503 compilation error. - Verified formatting with `dotnet format`. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 participant
Fixed an issue where variables in legacy storyboards were not correctly expanded if they were followed by a suffix. The decoder now uses a longest-prefix matching strategy. Also cleaned up some warnings.
PR created automatically by Jules for task 11597934844821820705 started by @winnerspiros