fix(android): add osu.Android to AndroidLinkSkip to fix JNI activation crash - #326
Merged
winnerspiros merged 3 commits intoMay 9, 2026
Conversation
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/a6d33ec1-71f4-441e-b6b0-8423692a44c1 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…ation constructor trimming Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/a6d33ec1-71f4-441e-b6b0-8423692a44c1 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
May 9, 2026 14:36
View session
|
|
…evious agent Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/e690eae3-823f-4fa4-b283-71c67ce38c1b Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
winnerspiros
approved these changes
May 9, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Android Release linker configuration by extending AndroidLinkSkip to include the osu.Android assembly, alongside an expanded comment explaining JNI activation crash context.
Changes:
- Add
osu.Androidto theAndroidLinkSkiplist inosu.Android.props. - Expand inline documentation describing why specific assemblies are excluded from ILLink trimming.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+127
to
+131
| osu.Android: contains OsuGameActivity whose build-generated (IntPtr, JniHandleOwnership) | ||
| JNI activation constructor (emitted by .NET Android build tooling for every [Activity] | ||
| subclass) has no managed callers and is trimmed by ILLink, causing the "Could not | ||
| activate JNI Handle … as managed type OsuGameActivity" crash at startup. --> | ||
| <AndroidLinkSkip>$(AndroidLinkSkip);osu.Android;osu.Framework.Android;SDL3-CS</AndroidLinkSkip> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./new_content.cs(leftover temp file from previous agent session)new_content.csandgithub-cookies.dbfrom repo root