perf: merge ppy/master + draw-call & allocation optimizations by Copilot · Pull Request #339 · winnerspiros/osu

Copilot · 2026-05-16T09:47:57Z

Investigate CI errors and warnings on branch copilot/fix-draw-call-performance
Fix TestFruitColourFallback / TestCustomFruitColourPriority failures in TestSceneHyperDashColouring.cs
Fix TestInsertedItemDoesNotRefreshAllOthers timeout in TestSceneMultiplayerPlaylist.cs

…7737) As requested in ppy#37734. Quick one, seems beneficial. --------- Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

This is _very_ uninspired. Although there are proposals for how this could be displayed, I'm purposefully taking the easy path here to not lock into a particular behaviour for this mechanic. https://github.com/user-attachments/assets/e37a62ea-118a-4cbe-bcc1-2ba93f17972c

…tent with everything else (ppy#37756) Closes ppy#37755.

…r grid changes) – fork wins conflicts Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…sualisation Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/fa63a9bf-af05-4ea4-8748-780d68da6902 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…→ .Count, LINQ-free LoadSamples Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/fa63a9bf-af05-4ea4-8748-780d68da6902 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

gitar-bot · 2026-05-16T09:49:03Z

Gitar is working

_Gitar

…ConfigManager .Any() fix Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/c114d967-cf97-4128-a9f7-ab72e272214e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…covariance fallback in LoadSamples, comment ModAdaptiveSpeed init Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/c114d967-cf97-4128-a9f7-ab72e272214e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…remove unused using in TestRoomRequestsHandler Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/d1f89c95-e9d0-4a2a-98c2-097c91531c79 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Just to let users know the nature of the system. https://github.com/user-attachments/assets/f0277791-4137-4d65-a27a-6aeb39e8b991

… AddUntilStep for hyper-dash colour assertion Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/0697207b-3aa5-4507-8b24-9b21f6d19860 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…hColouring Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/b4752d8a-e6d0-4e57-bd91-82deacfd4ee3 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…s, fix WebSocket overflow detection Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/b965837f-dc52-435f-adcf-02194826dc56 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…ank lines, redundant qualifiers) Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/f6a724cd-01fb-4c3e-8c92-b27fbcfada86 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…playlist ordering (correct PlaylistOrder in addItem) Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/50f21814-b4f6-4233-9cb0-428fd2329135 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/2432a0b5-4cd4-43e2-849b-ebf694737ae1 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…t playlist ordering to Position.Y Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/4c67b1c9-c61b-470a-9c20-6b1e2a261e3d Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…ering to PlaylistOrder Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5918ae2d-88c5-4b1f-aa60-f2d12b8e4ac9 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/25d444f7-30e4-4b5b-b6b2-23759a4fee69 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

… timeout Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/3401ec3e-61e1-4774-a089-4498dc83cf8e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…, covariant array, disposed closure, indent Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/df24fee2-e199-4954-a5a9-1ddcfecc3b97 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

The previous commit incorrectly removed type arguments from nameof() calls while trying to address InspectCode notes. This caused CS0305 ('Using generic type requires N type arguments') errors that broke all CI build jobs. Restored: - DrawableScrollingRuleset.cs: nameof(DrawableScrollingRuleset<TObject>) - RulesetInputManager.cs: nameof(ReplayState<T>) and nameof(RulesetInputManagerInputState<T>) - SettingsItem.cs: nameof(IHasCurrentValue<T>) Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/cc17a084-e741-46a9-822f-416eb135fc90 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

- Remove redundant `using System.Linq;` from MainMenuButton.cs (error) - Replace `System.Numerics.Vector2` with `Vector2` in 9 files with redundant qualifiers (warnings) - Fix null-conditional on non-nullable `existingRoom` in LoungeSubScreen.cs (warning) - Fix ternary line break formatting in DailyChallenge.cs (warning) - Remove redundant type args from nameof() in SettingsItem, DrawableScrollingRuleset, RulesetInputManager (notes) - Use `with` expression for struct copying in LinedPositionSnapGrid, RectangularPositionSnapGrid, MetronomeDisplay, TabletSettings, TabletAreaSelection, WikiPanelContainer, ModIcon, ConvertHitObject (notes) - Use `field` keyword for backing fields in PathControlPoint, DrawableRuleset, Nub, ProgressNotification, OverlayRulesetTabItem, OverlayTabControl, ProfileItemContainer, ModFlashlight (notes) Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/d2df9e0a-0c4e-428c-99df-6ab89eefe5e7 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/2e17044b-3164-4e7a-92ca-38cb1bb9eece Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

…e notes Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/58d50c00-60b8-43a1-b8e9-6c458c899d86 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

peppy and others added 7 commits May 13, 2026 12:49

Update framework

26d6366

Change editor grid slider adjustments to be relative to centre (ppy#3…

ba15798

…7737) As requested in ppy#37734. Quick one, seems beneficial. --------- Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Use truncation to 2dp of star rating in ranked play card to be consis…

c8bfb34

…tent with everything else (ppy#37756) Closes ppy#37755.

Merge ppy/master (star rating truncation, last stand indicator, edito…

232926f

…r grid changes) – fork wins conflicts Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

perf: guard invalidation in ParticleSpewer, ParticleExplosion, LogoVi…

df587d7

…sualisation Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/fa63a9bf-af05-4ea4-8748-780d68da6902 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

perf: span overloads in Parsing, allocation-free SplitKeyVal, .Any() …

43aeb8f

…→ .Count, LINQ-free LoadSamples Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/fa63a9bf-af05-4ea4-8748-780d68da6902 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Copilot AI assigned Copilot and winnerspiros May 16, 2026

Copilot created this pull request from a session on behalf of winnerspiros May 16, 2026 09:48 View session

Copilot finished work on behalf of winnerspiros May 16, 2026 09:48

Copilot AI requested a review from winnerspiros May 16, 2026 09:48

Copilot started work on behalf of winnerspiros May 16, 2026 09:50 View session

Copilot AI and others added 2 commits May 16, 2026 09:58

perf: GhostIcon IsPresent guard, ModAdaptiveSpeed alloc-free, Ruleset…

3d0e186

…ConfigManager .Any() fix Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/c114d967-cf97-4128-a9f7-ab72e272214e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Copilot finished work on behalf of winnerspiros May 16, 2026 10:02

winnerspiros approved these changes May 16, 2026

View reviewed changes

Copilot started work on behalf of winnerspiros May 16, 2026 10:08 View session

Copilot finished work on behalf of winnerspiros May 16, 2026 10:11

Copilot AI requested a review from winnerspiros May 16, 2026 10:11

winnerspiros approved these changes May 16, 2026

View reviewed changes

github-advanced-security AI found potential problems May 16, 2026

View reviewed changes

Comment thread osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs Fixed

Copilot started work on behalf of winnerspiros May 16, 2026 10:28 View session

smoogipoo and others added 2 commits May 16, 2026 20:17

Add experimental banner to ranked play queue screen (ppy#37767)

ade68dd

Just to let users know the nature of the system. https://github.com/user-attachments/assets/f0277791-4137-4d65-a27a-6aeb39e8b991

Copilot finished work on behalf of winnerspiros May 16, 2026 11:21

Copilot AI requested a review from winnerspiros May 16, 2026 11:21

winnerspiros approved these changes May 16, 2026

View reviewed changes